Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous integration on macOS #24

Closed
dtolnay opened this issue Jan 26, 2020 · 6 comments · Fixed by #31
Closed

Add continuous integration on macOS #24

dtolnay opened this issue Jan 26, 2020 · 6 comments · Fixed by #31

Comments

@dtolnay
Copy link
Owner

dtolnay commented Jan 26, 2020

No description provided.

@sayrer
Copy link
Contributor

sayrer commented Jan 26, 2020

I'd like to help with this and #25. Do you have a CI service you favor, or is that part of the problem to be solved?

@dtolnay
Copy link
Owner Author

dtolnay commented Jan 26, 2020

Hopefully Travis CI should be easy to get working. Something like https://github.com/dtolnay/link-cplusplus/blob/690c615e632d1f3ce5b9408b318b34642cd60e28/.travis.yml.

@sayrer
Copy link
Contributor

sayrer commented Jan 26, 2020

OK, Travis CI is a fine place to start.

@sayrer
Copy link
Contributor

sayrer commented Feb 3, 2020

Would you be open to adding Buck and Bazel builds to this? I'm not attached to a particular solution, but I'm not convinced the the description of cxxbridge-cmd is accurate yet.

@dtolnay
Copy link
Owner Author

dtolnay commented Feb 3, 2020

I would prefer not to tie that together with macOS CI, but I've filed separate issues to track Bazel and Buck CI.

@dtolnay
Copy link
Owner Author

dtolnay commented Feb 23, 2020

but I'm not convinced that the description of cxxbridge-cmd is accurate yet.

Now that we have build files for both Buck and Bazel and neither of them required source changes to the cxx crate or cxxbridge-cmd, hopefully you are convinced. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants