Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nacos registry #6

Merged
merged 1 commit into from
Jan 17, 2019
Merged

feat: support nacos registry #6

merged 1 commit into from
Jan 17, 2019

Conversation

gxcsoccer
Copy link
Contributor

@gxcsoccer gxcsoccer commented Jan 15, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #6 into master will decrease coverage by 13.97%.
The diff coverage is 84.7%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #6       +/-   ##
===========================================
- Coverage     100%   86.02%   -13.98%     
===========================================
  Files           2        3        +1     
  Lines          10       93       +83     
===========================================
+ Hits           10       80       +70     
- Misses          0       13       +13
Impacted Files Coverage Δ
lib/registry/zk.js 100% <ø> (ø)
config/config.default.js 100% <100%> (ø) ⬆️
lib/registry/nacos.js 82.66% <82.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc891ee...bf51da2. Read the comment docs.

@gxcsoccer gxcsoccer changed the title [WIP] feat: support nacos registry feat: support nacos registry Jan 15, 2019
@gxcsoccer gxcsoccer merged commit a180c7c into master Jan 17, 2019
@gxcsoccer gxcsoccer deleted the support-nacos branch January 17, 2019 09:54
@gxcsoccer gxcsoccer self-assigned this Jan 17, 2019
@gxcsoccer gxcsoccer added the enhancement New feature or request label Jan 17, 2019
@gxcsoccer
Copy link
Contributor Author

1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants