Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Get rid of use_theoretical_model #574

Closed
duburcqa opened this issue Sep 26, 2022 · 2 comments
Closed

[python] Get rid of use_theoretical_model #574

duburcqa opened this issue Sep 26, 2022 · 2 comments
Labels
core enhancement New feature or request P0 Highest priority issue

Comments

@duburcqa
Copy link
Owner

duburcqa commented Sep 26, 2022

We should get rid of use_theoretical_model everywhere to make everything more simple. The user would be responsible for converting the state for flexible to rigid or the other way around if necessary.

@duburcqa
Copy link
Owner Author

duburcqa commented Sep 26, 2022

Note that it is still relevant to create theoretical visual and collision models (at least internally), as they are used to generate the actual visual and collision models later on. Making them private would be an option, but it would require to move the "serialization" in Model itself, which is not ideal for now because of design flaws.

@duburcqa duburcqa added enhancement New feature or request core P1 Mid priority issue P0 Highest priority issue and removed P1 Mid priority issue labels Feb 11, 2023
@duburcqa duburcqa changed the title [python] Get rid of use_theoretical_model. [python] Get rid of use_theoretical_model Oct 9, 2023
@duburcqa
Copy link
Owner Author

Fixed by #753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core enhancement New feature or request P0 Highest priority issue
Projects
Status: Done
Development

No branches or pull requests

1 participant