Add --all flag for printing intermediate requests and responses #137

ducaale · 2021-05-05T18:47:50Z

Also adds the history_print flag for customizing printed sections for intermediate requests only.

Ticks another item from #4.

src/redirect.rs

ducaale · 2021-05-22T16:49:20Z

But it doesn't seem to match HTTPie yet. http --follow --print=HhBb httpbin.org/status/302 prints all the request bodies and only the final response body.

~~That sounds really unintuitive. Do you know why it ignores intermediate responses in this case?~~

Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>

src/main.rs

this is to avoid confusion with http redirect

blyxxyz · 2021-06-01T10:43:18Z

Do you know why it ignores intermediate responses in this case?

That's what --all is for. The weird thing is that it does print all requests even without --all.

I think we should file an issue with HTTPie for clarification to fix either the implementation or the documentation.

blyxxyz

From experimenting and digging around HTTPie's source code I think its --history-print is unused. Or maybe I'm missing something.

Printing the first request and last response by default seems reasonable to go with for now.

src/main.rs

blyxxyz

Two tiny nitpicks, but I'm also ok with ignoring them.

src/main.rs

blyxxyz · 2021-08-06T19:53:52Z

src/main.rs

+                client.on_redirect(|prev_response, next_request| {
+                    printer.print_response_headers(&prev_response)?;
+                    printer.print_response_body(prev_response)?;
+                    printer.print_seperator()?;


HTTPie doesn't have exactly this logic, http -v --print= --follow httpbin.org/status/302 has zero lines of output. (I haven't checked which logic it does use.)

I will look into this in a separate PR as I have a feeling that the fix will be a little bit more involved.

WIP: print intermediate requests/response for redirects

29cd22e

ducaale force-pushed the all-flag branch from 685bc20 to 29cd22e Compare May 12, 2021 14:37

ducaale added 5 commits May 12, 2021 16:20

print intermediate requests in correct order

57eb14d

handle relative location

1e72c0d

remove body-related headers from partially cloned requests

8522ebb

remove sensitive headers on cross redirect

32213aa

return error if max-redirects is exceeded

9b0e956

ducaale changed the title ~~Support printing intermediate requests and responses when redirecting~~ Add --all flag for printing intermediate requests and responses May 12, 2021

ducaale added 5 commits May 12, 2021 18:56

let printer determine what section to print

c7ddbd0

Merge branch 'sessions' into all-flag

cf4d1e4

Merge branch 'sessions' into all-flag

11f1d8e

Merge branch 'sessions' into all-flag

0675f27

add a basic test for the all flag

f98fa02

ducaale marked this pull request as ready for review May 12, 2021 21:39

ducaale commented May 12, 2021

View reviewed changes

src/redirect.rs Outdated Show resolved Hide resolved

ducaale added 7 commits May 13, 2021 16:25

add test for max-redirects

efe5617

get rid of unnecessary cloning

558742e

test method and body behaviour when redirecting

0db15f1

test removal of sensitive headers

ed0f0a1

test removal of content-headers in 302 redirects

d390f9f

a little bit of refactoring

f70f8fd

test redirect behaviour for non-cloneable bodies

123e192

ducaale requested a review from blyxxyz May 13, 2021 22:19

ducaale added 7 commits May 14, 2021 12:26

buffer request body before following redirects

f320114

Merge branch 'sessions' into all-flag

119409b

update negation flags

275bc5d

update manpages + completion files

e67e6c8

update README.md

85e9b81

enable check_status if download flag is enabled

fdf7b5c

fix failing test

034a370

remove unnecessary cloning

bfce8ff

ducaale and others added 2 commits May 22, 2021 18:28

Capitalize --all help text

8f3a5f2

Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>

rename on_redirect lambda parameters

a2073a2

ducaale commented May 22, 2021

View reviewed changes

src/main.rs Outdated Show resolved Hide resolved

ducaale added 2 commits May 30, 2021 20:55

Merge branch 'sessions' into all-flag

97f4c74

rename is_redirect

29b4764

this is to avoid confusion with http redirect

clarify what is intermediary request or response

79e58c6

blyxxyz mentioned this pull request Jun 9, 2021

Intermediate requests are being printed if --print=H flag is used httpie/cli#1082

Open

2 tasks

ducaale added 3 commits June 15, 2021 16:00

Merge branch 'sessions' into all-flag

8689088

support httpie's history_print flag

28d7e5a

Merge branch 'sessions' into all-flag

35289c8

This was referenced Jun 29, 2021

Add --native-tls flag #154

Merged

HTTPie feature parity checklist #4

Open

ducaale added 5 commits July 24, 2021 19:54

Merge branch 'sessions' into all-flag

592f87c

fix failed tests

0d761a1

Merge branch 'sessions' into all-flag

c5d199d

Merge branch 'sessions' into all-flag

d73d4a9

Merge branch 'sessions' into all-flag

ea0747d

blyxxyz requested changes Aug 3, 2021

View reviewed changes

src/main.rs Show resolved Hide resolved

Base automatically changed from sessions to develop August 5, 2021 15:56

Merge branch 'develop' into all-flag

fa580d5

blyxxyz approved these changes Aug 6, 2021

View reviewed changes

ducaale added 3 commits September 3, 2021 20:05

Merge branch 'develop' into all-flag

ae447b2

&T instead of Arc<T> in print_request_headers

60c17fb

fix clippy warning

e022ee1

ducaale merged commit 560b004 into develop Sep 3, 2021

ducaale deleted the all-flag branch September 3, 2021 18:03

ducaale mentioned this pull request Sep 10, 2021

Avoid printing unnecessary line separators #174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add --all flag for printing intermediate requests and responses #137

Add --all flag for printing intermediate requests and responses #137

ducaale commented May 5, 2021 •

edited

Loading

ducaale commented May 22, 2021 •

edited

Loading

blyxxyz commented Jun 1, 2021

blyxxyz left a comment

blyxxyz left a comment

blyxxyz Aug 6, 2021

ducaale Sep 3, 2021 •

edited

Loading

Add --all flag for printing intermediate requests and responses #137

Add --all flag for printing intermediate requests and responses #137

Conversation

ducaale commented May 5, 2021 • edited Loading

ducaale commented May 22, 2021 • edited Loading

blyxxyz commented Jun 1, 2021

blyxxyz left a comment

Choose a reason for hiding this comment

blyxxyz left a comment

Choose a reason for hiding this comment

blyxxyz Aug 6, 2021

Choose a reason for hiding this comment

ducaale Sep 3, 2021 • edited Loading

Choose a reason for hiding this comment

ducaale commented May 5, 2021 •

edited

Loading

ducaale commented May 22, 2021 •

edited

Loading

ducaale Sep 3, 2021 •

edited

Loading