Avoid printing unnecessary line separators #174
Conversation
For example, http -v --print= --follow httpbin.org/status/302 shouldn't print any separators
src/printer.rs
Outdated
| if self.print.request_body { | ||
| self.buffer.print("\n")?; | ||
| } |
There was a problem hiding this comment.
I am not a fan of this change so I will revisit this in a later PR when implementing a middleware system + Digest authentication.
src/printer.rs
Outdated
| // except for print_response_body. We are using this function when we have | ||
| // something to print after the response body. | ||
| pub fn print_separator(&mut self) -> io::Result<()> { | ||
| if self.print.request_body { |
There was a problem hiding this comment.
I'm not sure I understand this. It looks at the request_body setting, but it comes right after the response_body, right?
Would it make more sense to add the newline into whichever of print_request_body and print_response_body needs it?
(I'm also ok with ignoring this altogether, I don't know if matching the exact number of newlines is important as long as there are no unreasonably short or long gaps.)
There was a problem hiding this comment.
I'm not sure I understand this. It looks at the request_body setting, but it comes right after the response_body, right?
Aargh, I meant to check self.print.response_body instead of self.print.request_body.
Would it make more sense to add the newline into whichever of print_request_body and print_response_body needs it?
print_request_body does already print a newline. In contrast, print_response_body doesn't add a newline because it is usually the last thing that would be printed (except if it is an intermediate response).
There was a problem hiding this comment.
Ahh, now everything makes sense.
It might be clearer to inline print_separator at this point but I think it all works out.
Addresses #137 (comment)