Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numerical Battery Readout in Debug #90

Closed
Cralex opened this issue Sep 10, 2023 · 4 comments
Closed

Numerical Battery Readout in Debug #90

Cralex opened this issue Sep 10, 2023 · 4 comments

Comments

@Cralex
Copy link
Contributor

Cralex commented Sep 10, 2023

As far as I'm aware, it's possible to see the battery level in two places: over serial when connected to power and the graphical icon. I'd like to see it added to the Debug menu as well if possible. I've got two (sluggish) ports in progress and I feel that it would be helpful to be able to watch a numerical battery estimate go down over time in the menu somewhere, just to help me know if I've got the battery gauge configured correctly. (Over serial, there's a good chance it would be fully charged anyway, or I might not have it set up right and it'd show a false 0 or 100 that never changes.)

@ducalex
Copy link
Owner

ducalex commented Sep 11, 2023

Makes sense to me and I'm guessing it's as simple as calling rg_input_read_battery in rg_gui_debug_menu.

Do you want to do it? Or I can do it if you prefer to skip the whole PR process but I won't be able to test it right now.

@Cralex
Copy link
Contributor Author

Cralex commented Oct 27, 2023

Added in my pull request. This will cause the percentage and voltage to appear in the debug menu. The menu doesn't refresh over time, so you'd need to check back if you're looking for something to change.
Photo Oct 27 2023, 4 52 31 PM
I had some help from AI to put this in, so it could probably be nicer with a human touch, but it's a start and it works.

@ducalex
Copy link
Owner

ducalex commented Oct 29, 2023

Yeah live update is possible but pretty complicated with our dialog system :(

Looking good, I left a comment on the PR just to double check something and then we can merge it.

@ducalex
Copy link
Owner

ducalex commented Jan 17, 2024

This was completed in PR#92.

@ducalex ducalex closed this as completed Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants