DUCKDB_TYPE_UHUGEINT breaks compatibility with C api clients

[Giorgi]

What happens?

In the DUCKDB_TYPE enum a new member, DUCKDB_TYPE_UHUGEINT was inserted in the middle causing all other member values to increment. This breaks compatibility with every library that uses C Api.

To Reproduce

Try using an existing library with DuckDB 0.10.0

OS:

Doesn't matter

DuckDB Version:

0.10.0

DuckDB Client:

Any client via C API

Full Name:

Giorgi Dalakishvili

Affiliation:

Space International

Have you tried this on the latest nightly build?

I have tested with a nightly build

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

• Yes, I have

[ak-coram]

I'm not sure this is a good idea since it essentially would break compatibility again (with 0.10.0), but I agree that this should be done for similar changes in the future.

[Mytherin]

Thanks for the report! It is indeed unfortunate that this broke C ABI compatibility in a way that could have been avoided. I will submit a patch to add explicit enum numbering and add a warning to ensure we don't break this again in the future.

[Giorgi]

There are lots of libraries that are compatible with DuckDB <=0.9.2 that all broke with today's release. I'm sure most of them will not be updated by the time a bug-fix release 0.10.1 is released. The last time it was released in just two weeks after the previous release. In my opinion, it would be better to break compatibility with 0.10.0 (if there is anything that will be broken at all) and have everything work again rather than have it permanently broken for so many existing libraries.

[Giorgi]

Thanks @Mytherin