Add support for right_semi and right_anti. PR 2 #9897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HT_ANTI and RIGHT_SEMI
…results are only propagated once
…new pointers exhausted script
2 tasks
Mytherin
reviewed
Dec 6, 2023
| @@ -49,7 +49,7 @@ class PhysicalPiecewiseMergeJoin : public PhysicalRangeJoin { | |||
| SourceResultType GetData(ExecutionContext &context, DataChunk &chunk, OperatorSourceInput &input) const override; | |||
|
|
|||
| bool IsSource() const override { | |||
| return IsRightOuterJoin(join_type); | |||
| return PropogatesBuildSide(join_type); | |||
There was a problem hiding this comment.
typo: PropagatesBuildSide
| size_t has_range = 0; | ||
| for (size_t c = 0; c < op.conditions.size(); ++c) { | ||
| auto &cond = op.conditions[c]; | ||
| bool PhysicalPlanGenerator::HasEquality(vector<JoinCondition> &conds, idx_t &has_range) { |
There was a problem hiding this comment.
nit: can we either turn has_range into a bool or rename it to range_count
lnkuiper
suggested changes
Dec 7, 2023
| @@ -17,6 +17,7 @@ bool PhysicalJoin::EmptyResultIfRHSIsEmpty() const { | |||
| case JoinType::INNER: | |||
| case JoinType::RIGHT: | |||
| case JoinType::SEMI: | |||
| case JoinType::RIGHT_ANTI: | |||
There was a problem hiding this comment.
Shouldn't RIGHT_SEMI also be in this switch?
There was a problem hiding this comment.
For some reason I remember taking this out because some tests with "IS NOT DISTINCT " conditions were failing. But those same issues would happen for right joins. so I'll add it back in
| // (and NULL if no partner is found) | ||
| RIGHT_SEMI = 9, |
There was a problem hiding this comment.
Would be nice to add a comment here explaining what the JoinTypes do like for the others
|
Thanks! |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9985 from hawkfish/summarize-overflow Merge pull request duckdb/duckdb#9972 from yiyuanliu/lyy/fix-9949 Merge pull request duckdb/duckdb#9962 from Tishj/statement_error_expected_non_optional Merge pull request duckdb/duckdb#9961 from Tishj/python_supply_config_to_connect Merge pull request duckdb/duckdb#9947 from taniabogatsch/list-intersect Merge pull request duckdb/duckdb#9568 from Jens-H/append-BigDecimal Merge pull request duckdb/duckdb#9959 from Tishj/python_udf_arrow_side_effects Merge pull request duckdb/duckdb#9855 from StarveZhou/issue_9795_arg Merge pull request duckdb/duckdb#9944 from Tishj/pyproject_toml Merge pull request duckdb/duckdb#9946 from lnkuiper/issue9718 Merge pull request duckdb/duckdb#9953 from mlafeldt/fix-httpfs-null-ptr Merge pull request duckdb/duckdb#9897 from Tmonster/left_semi_anti_feature_rebased Merge pull request duckdb/duckdb#9936 from hawkfish/empty-frames Merge pull request duckdb/duckdb#9715 from Tishj/dependency_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of this PR. Moved here since the commit history was getting muddy. The original PR was based off of the feature branch.
#9406
Add right semi and right anti join support.
the operators for right anti and right semi utilize the same operator for right joins, but with one adjustment.
trueand propagating the result, we only mark the match in the hash table withtruetruematch.This will not work for any other join operator type that is not a hash join. There is a check in the join order optimizer to make sure the (semi/anti) join conditions have an equality. If the conditions do not have this equality, we do not switch the children.
There is also better cardinality estimation for semi/anti joins.