New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQLLogicTest] Expected error message is no longer optional for statement error
#9962
Merged
Mytherin
merged 12 commits into
duckdb:main
from
Tishj:statement_error_expected_non_optional
Dec 12, 2023
Merged
[SQLLogicTest] Expected error message is no longer optional for statement error
#9962
Mytherin
merged 12 commits into
duckdb:main
from
Tishj:statement_error_expected_non_optional
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pected error to have a trailing '----'
…ected_non_optional
…ected_non_optional
Thanks! I think this will break the SQLLogicTests and some extensions (and perhaps more) - but let's just get this in now and fix those after. |
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9985 from hawkfish/summarize-overflow Merge pull request duckdb/duckdb#9972 from yiyuanliu/lyy/fix-9949 Merge pull request duckdb/duckdb#9962 from Tishj/statement_error_expected_non_optional Merge pull request duckdb/duckdb#9961 from Tishj/python_supply_config_to_connect Merge pull request duckdb/duckdb#9947 from taniabogatsch/list-intersect Merge pull request duckdb/duckdb#9568 from Jens-H/append-BigDecimal Merge pull request duckdb/duckdb#9959 from Tishj/python_udf_arrow_side_effects Merge pull request duckdb/duckdb#9855 from StarveZhou/issue_9795_arg Merge pull request duckdb/duckdb#9944 from Tishj/pyproject_toml Merge pull request duckdb/duckdb#9946 from lnkuiper/issue9718 Merge pull request duckdb/duckdb#9953 from mlafeldt/fix-httpfs-null-ptr Merge pull request duckdb/duckdb#9897 from Tmonster/left_semi_anti_feature_rebased Merge pull request duckdb/duckdb#9936 from hawkfish/empty-frames Merge pull request duckdb/duckdb#9715 from Tishj/dependency_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was accepted:
statement error select non_existant_function();
Now this will fail to parse:
Instead the minimal syntax for a
statement error
is:The hope is that this will encourage all statement errors going forward to provide an expected error message in addition to the now required
----
and to incrementally fix oldstatement error
statements by adding a proper expected error message pattern.