Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLLogicTest] Expected error message is no longer optional for statement error #9962

Merged
merged 12 commits into from Dec 12, 2023

Conversation

Tishj
Copy link
Contributor

@Tishj Tishj commented Dec 12, 2023

Previously this was accepted:

statement error
select non_existant_function();

Now this will fail to parse:

/Users/thijs/DuckDBLabs/duckdb/test/sqlite/sqllogic_parser.cpp:115: FAILED:
explicitly with message:
  test/tmp/tmp.test:3: Failed to parse statement: statement error needs to have
  an expected error message

Instead the minimal syntax for a statement error is:

statement error
select non_existant_function();
----

The hope is that this will encourage all statement errors going forward to provide an expected error message in addition to the now required ---- and to incrementally fix old statement error statements by adding a proper expected error message pattern.

@github-actions github-actions bot marked this pull request as draft December 12, 2023 12:00
@Tishj Tishj marked this pull request as ready for review December 12, 2023 12:00
@github-actions github-actions bot marked this pull request as draft December 12, 2023 14:06
@Tishj Tishj marked this pull request as ready for review December 12, 2023 14:57
@Mytherin Mytherin merged commit 3237244 into duckdb:main Dec 12, 2023
27 checks passed
@Mytherin
Copy link
Collaborator

Thanks! I think this will break the SQLLogicTests and some extensions (and perhaps more) - but let's just get this in now and fix those after.

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
Merge pull request duckdb/duckdb#9985 from hawkfish/summarize-overflow
Merge pull request duckdb/duckdb#9972 from yiyuanliu/lyy/fix-9949
Merge pull request duckdb/duckdb#9962 from Tishj/statement_error_expected_non_optional
Merge pull request duckdb/duckdb#9961 from Tishj/python_supply_config_to_connect
Merge pull request duckdb/duckdb#9947 from taniabogatsch/list-intersect
Merge pull request duckdb/duckdb#9568 from Jens-H/append-BigDecimal
Merge pull request duckdb/duckdb#9959 from Tishj/python_udf_arrow_side_effects
Merge pull request duckdb/duckdb#9855 from StarveZhou/issue_9795_arg
Merge pull request duckdb/duckdb#9944 from Tishj/pyproject_toml
Merge pull request duckdb/duckdb#9946 from lnkuiper/issue9718
Merge pull request duckdb/duckdb#9953 from mlafeldt/fix-httpfs-null-ptr
Merge pull request duckdb/duckdb#9897 from Tmonster/left_semi_anti_feature_rebased
Merge pull request duckdb/duckdb#9936 from hawkfish/empty-frames
Merge pull request duckdb/duckdb#9715 from Tishj/dependency_set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants