[Fix] No duplicates in list_intersect #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #9942. |
|
Thanks! |
1 task
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9985 from hawkfish/summarize-overflow Merge pull request duckdb/duckdb#9972 from yiyuanliu/lyy/fix-9949 Merge pull request duckdb/duckdb#9962 from Tishj/statement_error_expected_non_optional Merge pull request duckdb/duckdb#9961 from Tishj/python_supply_config_to_connect Merge pull request duckdb/duckdb#9947 from taniabogatsch/list-intersect Merge pull request duckdb/duckdb#9568 from Jens-H/append-BigDecimal Merge pull request duckdb/duckdb#9959 from Tishj/python_udf_arrow_side_effects Merge pull request duckdb/duckdb#9855 from StarveZhou/issue_9795_arg Merge pull request duckdb/duckdb#9944 from Tishj/pyproject_toml Merge pull request duckdb/duckdb#9946 from lnkuiper/issue9718 Merge pull request duckdb/duckdb#9953 from mlafeldt/fix-httpfs-null-ptr Merge pull request duckdb/duckdb#9897 from Tmonster/left_semi_anti_feature_rebased Merge pull request duckdb/duckdb#9936 from hawkfish/empty-frames Merge pull request duckdb/duckdb#9715 from Tishj/dependency_set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
list_intersectrewrite fromlist_filter(l1, (x) -> list_contains(l2, x))tolist_filter(list_distinct(l1), (x) -> list_contains(l2, x)). As a result,list_intersectno longer returns duplicate values.However, the drawback of this change is that
list_intersectnow requireslist_distinct, which uses duckdb'shistogramaggregate function internally. Thehistogramfunction cannot handle nested inputs yet, as well as some maximum values for huge integers and blobs. This limits the functionality oflist_intersectbut ensures correct results according to set logic.