New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADS: Release #2668
ADS: Release #2668
Commits on Jan 24, 2023
-
ADS DaxTextView: Support for android:textColor (#2546)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203418290512953 ### Description - Support the textColor attribute from Android - When textType and textColor are both set, textType will take priority.
Configuration menu - View commit details
-
Copy full SHA for 4ecd813 - Browse repository at this point
Copy the full SHA 4ecd813View commit details -
ADS: Add a custom CardView for DaxDialogs (#2550)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203425281067996 ### Description The top triangle in the DaxDialog doesn't respect elevation. The outline around it is not consistent with the rest of the Card. ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221122_174516](https://user-images.githubusercontent.com/531613/203578300-1a80b73e-cb28-441c-831c-cb9a1307319f.png)|![Screenshot_20221123_140401](https://user-images.githubusercontent.com/531613/203578315-8778a408-8158-40f3-ae88-d1bc3039937a.png)|
Configuration menu - View commit details
-
Copy full SHA for cc2409e - Browse repository at this point
Copy the full SHA cc2409eView commit details -
ADS: Edit padding-end toggle in ListItems (#2560)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/1202857801505092/1203433424223914/f ### Description Increase padding-end for OneLineListItem and TwoLineListItem when showing switch ### Steps to test this PR - Install from this branch - Go to Settings > Design Preview - [ ] Check List Items with toggle look as expected ### UI changes | Before | After | | ------ | ----- | ![autoconsent_old_light](https://user-images.githubusercontent.com/20798495/203793730-c9d9883e-c2a8-48bd-8a9e-6c19288f2f92.jpg)|![padding-end_16dp](https://user-images.githubusercontent.com/20798495/203793656-dae94b23-c40c-4d3b-8dce-65f8f9a4f539.jpg)|
Configuration menu - View commit details
-
Copy full SHA for aacf8f7 - Browse repository at this point
Copy the full SHA aacf8f7View commit details -
Task/Issue URL: https://app.asana.com/0/488551667048375/1203325011590293 ### Description Update Onboarding to ADS ### UI changes | Onboarding | Onboarding | Onboarding | Onboarding | | ------ | ----- | ------ | ----- | ![Screenshot_20221124_105952](https://user-images.githubusercontent.com/531613/203755369-9dcee675-b819-428f-a1b3-8351a910ba24.png)|![Screenshot_20221124_105927](https://user-images.githubusercontent.com/531613/203755382-ad2b4346-82b1-4aab-ab50-766530e9ec7b.png)|![Screenshot_20221124_110004](https://user-images.githubusercontent.com/531613/203755362-3d2069d2-5395-467a-8d6f-3575fcd3fff0.png)|![Screenshot_20221124_105912](https://user-images.githubusercontent.com/531613/203755392-191034c5-fde4-475b-9d34-818fcf22f331.png)|
Configuration menu - View commit details
-
Copy full SHA for eeb2b8a - Browse repository at this point
Copy the full SHA eeb2b8aView commit details -
ADS: Add a custom CardView for DaxDialogs (#2550)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203425281067996 ### Description The top triangle in the DaxDialog doesn't respect elevation. The outline around it is not consistent with the rest of the Card. ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221122_174516](https://user-images.githubusercontent.com/531613/203578300-1a80b73e-cb28-441c-831c-cb9a1307319f.png)|![Screenshot_20221123_140401](https://user-images.githubusercontent.com/531613/203578315-8778a408-8158-40f3-ae88-d1bc3039937a.png)|
Configuration menu - View commit details
-
Copy full SHA for ad1d3ad - Browse repository at this point
Copy the full SHA ad1d3adView commit details -
ADS: GPC screen migration (#2557)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/0/1203418963160798/f ### Description Global Privacy Control screen 100% migrated to new components ### Steps to test this PR - Install from this branch - Go to Settings > Global Privacy Control (GPC) - [ ] Check screen looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221124-100149_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203757021-1b931a7a-dfbb-41fb-92af-e30c6faa88f9.jpg)|![Screenshot_20221124-100405_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203757276-10fd5129-0a87-45ae-a864-695c2b1c6793.jpg)| ![Screenshot_20221124-100341_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203757037-57eb0cff-cd1b-4342-bece-42d22f06ea46.jpg)|![Screenshot_20221124-100356_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203757306-54f4072d-22c1-4bd5-91a7-dc9fc4b73851.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 2a49f56 - Browse repository at this point
Copy the full SHA 2a49f56View commit details -
ADS: Manage Cookie Pop-ups migration (#2559)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/0/1203418963160799/f ### Description Manage Cookie Pop-ups screen 100% migrated to new components ### Steps to test this PR - Install from this branch - Go to Settings > Manage Cookie Pop-ups - [ ] Check screen looks as expected ### UI changes | Before | After | | ------ | ----- | ![autoconsent_old_light](https://user-images.githubusercontent.com/20798495/203774974-082d4088-f957-4be8-81aa-7e8735eed21e.jpg)|![autoconsent_new_light](https://user-images.githubusercontent.com/20798495/203776081-2ea13174-f709-4b34-9473-933438dc33b6.jpg)| ![autoconsent_old_dark](https://user-images.githubusercontent.com/20798495/203774991-473012a1-a9c7-40a4-b97d-be230f07614a.jpg)|![autoconsent_new_dark](https://user-images.githubusercontent.com/20798495/203776142-97517f5c-c4c4-431d-a8b1-cf10dad3887d.jpg)|
Configuration menu - View commit details
-
Copy full SHA for eddd8f8 - Browse repository at this point
Copy the full SHA eddd8f8View commit details -
ADS: Accessibility screen migration (#2553)
Task/Issue URL: https://app.asana.com/0/0/1203418963160797/f ### Description Accessibility screen 100% migrated to new components ### Steps to test this PR - Install from this branch - Go to Settings > Accessibility - [ ] Check screen looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221123-171045_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203611688-2e940e30-79a6-46b6-b641-02c162f975a7.jpg)|![Screenshot_20221124-101518_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203759185-7398bb92-b372-4182-bf36-266dde6f555c.jpg)| ![Screenshot_20221124-101542_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203759120-a2230381-80c3-4648-a79b-e6d79f0a624d.jpg)|![Screenshot_20221124-101507_DuckDuckGo](https://user-images.githubusercontent.com/20798495/203759152-68b12852-8705-4c4b-9c6a-6930cefca7c1.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 88c9a7e - Browse repository at this point
Copy the full SHA 88c9a7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 590e9e9 - Browse repository at this point
Copy the full SHA 590e9e9View commit details -
ADS: Framework related colors (#2567)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 Update toolbar, statusbar and navigation bar colors to latest spec | Light | Dark| | ------ | ----- | ![Screenshot_20221125_151024](https://user-images.githubusercontent.com/531613/204002612-76f95631-0dea-4bb4-a84a-251150a0dfb5.png)|![Screenshot_20221125_150923](https://user-images.githubusercontent.com/531613/204002617-3e850e89-1ea1-416d-b97a-b1b1fc790278.png)| Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 98dd27c - Browse repository at this point
Copy the full SHA 98dd27cView commit details -
Configuration menu - View commit details
-
Copy full SHA for eac893f - Browse repository at this point
Copy the full SHA eac893fView commit details -
ADS: Framework related colors 2 (#2574)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | ![Screenshot_20221125_151024](https://user-images.githubusercontent.com/531613/204002612-76f95631-0dea-4bb4-a84a-251150a0dfb5.png)|![Screenshot_20221125_150923](https://user-images.githubusercontent.com/531613/204002617-3e850e89-1ea1-416d-b97a-b1b1fc790278.png)| Co-authored-by: David González <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0f67969 - Browse repository at this point
Copy the full SHA 0f67969View commit details -
Task/Issue URL: https://app.asana.com/0/488551667048375/1203325011590293 Update Onboarding to ADS | Onboarding | Onboarding | Onboarding | Onboarding | | ------ | ----- | ------ | ----- | ![Screenshot_20221124_105952](https://user-images.githubusercontent.com/531613/203755369-9dcee675-b819-428f-a1b3-8351a910ba24.png)|![Screenshot_20221124_105927](https://user-images.githubusercontent.com/531613/203755382-ad2b4346-82b1-4aab-ab50-766530e9ec7b.png)|![Screenshot_20221124_110004](https://user-images.githubusercontent.com/531613/203755362-3d2069d2-5395-467a-8d6f-3575fcd3fff0.png)|![Screenshot_20221124_105912](https://user-images.githubusercontent.com/531613/203755392-191034c5-fde4-475b-9d34-818fcf22f331.png)|
Configuration menu - View commit details
-
Copy full SHA for e51cc00 - Browse repository at this point
Copy the full SHA e51cc00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33fd47c - Browse repository at this point
Copy the full SHA 33fd47cView commit details -
ADS: Framework related colors (#2567)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 Update toolbar, statusbar and navigation bar colors to latest spec | Light | Dark| | ------ | ----- | ![Screenshot_20221125_151024](https://user-images.githubusercontent.com/531613/204002612-76f95631-0dea-4bb4-a84a-251150a0dfb5.png)|![Screenshot_20221125_150923](https://user-images.githubusercontent.com/531613/204002617-3e850e89-1ea1-416d-b97a-b1b1fc790278.png)| Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a2e368 - Browse repository at this point
Copy the full SHA 1a2e368View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7edbe81 - Browse repository at this point
Copy the full SHA 7edbe81View commit details -
ADS: Framework related colors 2 (#2574)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203412677059168 ### Description Update toolbar, statusbar and navigation bar colors to latest spec ### UI changes | Light | Dark| | ------ | ----- | ![Screenshot_20221125_151024](https://user-images.githubusercontent.com/531613/204002612-76f95631-0dea-4bb4-a84a-251150a0dfb5.png)|![Screenshot_20221125_150923](https://user-images.githubusercontent.com/531613/204002617-3e850e89-1ea1-416d-b97a-b1b1fc790278.png)| Co-authored-by: David González <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 53fd656 - Browse repository at this point
Copy the full SHA 53fd656View commit details -
ADS: Fix selected option in RadioListDialog (#2577)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203456015669172/f ### Description - Selected option was not working for RadioListAlertDialogBuilder - Disable positive button if no option is selected by default ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221129-115404_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204546959-54f42f96-fffc-42bc-9821-b39f7d201146.jpg)|![Screenshot_20221129-134905_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204546976-cbda520d-e338-4636-aa99-57b358f89599.jpg)| ![Screenshot_20221129-115404_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204546959-54f42f96-fffc-42bc-9821-b39f7d201146.jpg)|![Screenshot_20221129-143842_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204576904-e45e9893-87c3-4ec3-aeb6-4676d0563261.jpg)|
Configuration menu - View commit details
-
Copy full SHA for fbbc52c - Browse repository at this point
Copy the full SHA fbbc52cView commit details -
ADS: Internal Features Settings migration (#2576)
Task/Issue URL: https://app.asana.com/0/0/1203418963160800/f ### Description Migrate internal features settings section to new components
Configuration menu - View commit details
-
Copy full SHA for 2acb14c - Browse repository at this point
Copy the full SHA 2acb14cView commit details -
ADS: Typography Review (#2572)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203438184524173 ### Description Update typograhpy to use lineHeight instead of lineSpacingExtra Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7c22e38 - Browse repository at this point
Copy the full SHA 7c22e38View commit details -
ADS: Browser Toolbar and Overlays (#2589)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203310952591148 Design Review in https://app.asana.com/0/1174433894299346/1203455585574660 Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b389f9e - Browse repository at this point
Copy the full SHA b389f9eView commit details -
ADS: Fireproof Websites screen migration (#2594)
Task/Issue URL: https://app.asana.com/0/0/1203467500325942/f ### Description Migration of Fireproof Websites screen to new components ### Steps to test this PR - Install from this branch - Go to Settings > Fireproof Websites - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221202-114053_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205285445-88b27ff9-1484-4bf0-9545-e65b64691feb.jpg)|![Screenshot_20221202-104630_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205285481-7c150f58-5735-49b7-90de-d002faac2b15.jpg)| ![Screenshot_20221202-114120_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205285469-b0e3c39d-0def-434f-b036-61b8f812a2e0.jpg)|![Screenshot_20221202-112656_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205285511-bb3525b3-c251-42bf-9b20-ef571f6f1151.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 77cd22a - Browse repository at this point
Copy the full SHA 77cd22aView commit details -
ADS: Settings Screen migration (#2590)
Task/Issue URL: https://app.asana.com/0/0/1203411647299661/f Migrate Settings screen and small section to new components - Main Settings menu - Theme Dialog - App Icon Screen - Fire Button Animation Dialog - Automatically Clear... Dialog - Clear On... Dialog - Open Links in Apps Dialog - DuckSuckGo Desktop App Screen - About DuckDuckGo Screen - Install from this branch - Go to Settings - [ ] Check settings menu, dialogs and screens mention in description look as expected | Before | After | | ------ | ----- | ![Screenshot_20221130-181442_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204876902-c02e41a3-6ff4-40a9-9b04-82cf8206b2d6.jpg)|![Screenshot_20221130-181455_DuckDuckGo](https://user-images.githubusercontent.com/20798495/204876842-55c26244-32c1-4c54-adb6-7572b8862d90.jpg)| Co-authored-by: David González <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for eb620cb - Browse repository at this point
Copy the full SHA eb620cbView commit details -
ADS: Scrollable RadioGroup in RadioListAlertDialog (#2609)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203480450171661/f ### Description Fix for making radiogroup scrollable if content is too long ### Steps to test this PR - Install from this branch - Change your device language to Russian - Go to Settings > Clear On... - [ ] Check content is scrollable ### UI changes | Before | After | | ------ | ----- | ![Screenshot 2022-12-02 at 16 01 19](https://user-images.githubusercontent.com/20798495/206157601-c569514b-e322-492c-a5aa-1e0c04955b9d.png)|https://user-images.githubusercontent.com/20798495/206157619-bab38fb5-90bb-486a-b3ba-efd61b334d31.mp4|
Configuration menu - View commit details
-
Copy full SHA for e53c33a - Browse repository at this point
Copy the full SHA e53c33aView commit details -
ADS: Divider Color in Dark Mode (#2616)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203501746286788 ### Description Update divider color attribute in dark mode
Configuration menu - View commit details
-
Copy full SHA for 5cf2c79 - Browse repository at this point
Copy the full SHA 5cf2c79View commit details -
ADS: Site Permissions section migration (#2588)
Task/Issue URL: https://app.asana.com/0/0/1203411647299660/f ### Description Migrate Site permissions section to new components ### Steps to test this PR - Install from this branch - Go to Settings > Site Permissions - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221202-114739_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205287199-ca0c20df-0df7-41f5-aac0-3d617553f16c.jpg)|![Screenshot_20221201-142533_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205286967-24cc6b46-9d94-4324-9556-c179803167eb.jpg)| ![Screenshot_20221202-114756_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205287213-f2fdb15d-2750-42f0-9def-7897eedb2fdc.jpg)|![Screenshot_20221201-142543_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205286917-a6a9160c-1bb7-4e48-8255-22a2458b2a31.jpg)|
Configuration menu - View commit details
-
Copy full SHA for f08d4ae - Browse repository at this point
Copy the full SHA f08d4aeView commit details -
ADS: Unprotected Sites migration (#2606)
Task/Issue URL: https://app.asana.com/0/0/1203467500325941/f ### Description - Migrate Unprotected Sites screen to new components - Created new CustomAlertDialog component ### Steps to test this PR - Install from this branch - Go to Settings > Unprotected Sites - [ ] Check screen look as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221206_180155_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205987523-0e85ae6f-3fb7-4e9a-a71c-23f396584966.jpg)|![Screenshot_20221206_141121_DuckDuckGo](https://user-images.githubusercontent.com/20798495/205987409-c1bfbb9e-2ef6-439a-95e2-87bd28ba24e8.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 57e6633 - Browse repository at this point
Copy the full SHA 57e6633View commit details -
ADS: Downloads screen migration (#2610)
Task/Issue URL: https://app.asana.com/0/0/1203411647299663/f ### Description Migrate Downloads screen to new components ### Steps to test this PR - Install from this branch - Go to Downloads - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221207_140218_DuckDuckGo](https://user-images.githubusercontent.com/20798495/206199425-9fbdb8a9-3b6e-4796-975d-ed1d0ed603bf.jpg)|![Screenshot_20221207_132951_DuckDuckGo](https://user-images.githubusercontent.com/20798495/206198560-ce6a6c45-16f2-4fb0-9f20-aed5c9e219ce.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 9ab2e43 - Browse repository at this point
Copy the full SHA 9ab2e43View commit details -
ADS: DaxTextInput specs (#2622)
Task/Issue URL: https://app.asana.com/0/1202857801505092/1203501746286791 Description Update TextInput to latest specs
Configuration menu - View commit details
-
Copy full SHA for c51ba7c - Browse repository at this point
Copy the full SHA c51ba7cView commit details -
Task/Issue URL: https://app.asana.com/0/inbox/1157893581871899/1203455585574665/1203472619504664 ### Description System Search changes Co-authored-by: Noelia Alcala <nalcalag@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3782b4a - Browse repository at this point
Copy the full SHA 3782b4aView commit details -
ADS: Bookmarks migration (#2629)
Task/Issue URL: https://app.asana.com/0/0/1203411647299662/f ### Description Migrate Bookmarks section to new ADS components ### Steps to test this PR - Install from this branch - Go to Bookmarks - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221213_102855_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207294198-efb78249-b069-4a3d-a4ee-5f41ff8044f9.jpg)|![Screenshot_20221213_101924_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207294348-58141c01-061a-4110-b134-12d7eba25224.jpg)| ![Screenshot_20221213_102953_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207294220-4b51fb2c-51fa-4a98-8a89-01f5982ff1d8.jpg)|![Screenshot_20221213_101956_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207294301-fcd41476-a7e5-4dc4-a6c1-90920bb35321.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 98e6edc - Browse repository at this point
Copy the full SHA 98e6edcView commit details -
ADS: Report Broken Sites migration (#2636)
Task/Issue URL: https://app.asana.com/0/0/1203411647299659/f ### Description Migrate Report Broken Sites screen to new ADS components ### Steps to test this PR - Install from this branch - Navigate to a website - Go to "Report Broken Site" option in the overflow menu - [ ] Check everything looks as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221214_100927_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207567541-c38fcdc0-d4d0-4c0e-af76-8196b4c2eded.jpg)|![Screenshot_20221214_101312_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207568133-0e988815-aec5-45ec-9c7f-581fa229d37f.jpg)| ![Screenshot_20221213_155234_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207567691-afec6e7b-dcca-4cbe-8e55-565ebe76d617.jpg)|![Screenshot_20221214_094609_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207567568-e79b8424-9335-4119-9ef9-8ae8870a83aa.jpg)|
Configuration menu - View commit details
-
Copy full SHA for cc59e21 - Browse repository at this point
Copy the full SHA cc59e21View commit details -
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203464673670509 ### Description Update Browser dialogs to latest spec, check task for details Co-authored-by: Aitor Viana <aitorvs@gmail.com> Co-authored-by: David <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1daa37f - Browse repository at this point
Copy the full SHA 1daa37fView commit details -
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203411647299664 Design Review Task: https://app.asana.com/0/0/1203569245422155/f ### Description Update Tab switcher screen Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for afbf1e8 - Browse repository at this point
Copy the full SHA afbf1e8View commit details -
ADS: Update Bottom Sheets styles in Browser (#2653)
Task/Issue URL: https://app.asana.com/0/0/1203464345362360/f Migrate bottom sheets in Browser to new styling **_Downloads_** - Install from this branch - Download a file - [x] Check bottom sheet looks as expected **_Fire Dialog_** - Install from this branch - Tap Fire Button - [x] Check bottom sheet looks as expected **_Email Tooltip_** - Install from this branch - Sign in on Duck Email Protection - Go to any sign in website - Tap on the duck icon in the login input element - [x] Check bottom sheet looks as expected **_Navigation History_** - Install from this branch - Navigate to few sites - Long tap on back button (nav bar) - [x] Check bottom sheet looks as expected | Before | After | | ------ | ----- | ![downloads-bottom-sheet](https://user-images.githubusercontent.com/20798495/208082681-a25cb7bf-e61c-413a-a0c7-d5e0b1fdbfa0.jpg)|![Screenshot_20221215_165818_DuckDuckGo](https://user-images.githubusercontent.com/20798495/208082801-4f45cab9-6958-40a3-8681-d018d0ccd418.jpg)| ![fire-bottom-sheet](https://user-images.githubusercontent.com/20798495/208082702-2365ad4c-447c-4fd0-8bd2-32c3d01a38b6.jpg)|![Screenshot_20221215_162950_DuckDuckGo](https://user-images.githubusercontent.com/20798495/208082945-402c2760-5e70-40ee-9b39-a295eac74789.jpg)| ![email-bottom-sheet](https://user-images.githubusercontent.com/20798495/208082724-7f508b28-06f6-45ff-8e7c-9efac06862f1.jpg)|![Screenshot_20221215_162704_DuckDuckGo](https://user-images.githubusercontent.com/20798495/208082998-73a33ff2-3109-429d-87d1-58d84a1e14f3.jpg)| ![navigation-history-bottom-sheet](https://user-images.githubusercontent.com/20798495/208082746-0ffca4dd-8863-4001-bc45-624a11f530d2.jpg)|![Screenshot_20221215_145128_DuckDuckGo](https://user-images.githubusercontent.com/20798495/208082862-3406af9b-233b-4fc6-9c5c-d091d34153bb.jpg)| Co-authored-by: David <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 56b1bd6 - Browse repository at this point
Copy the full SHA 56b1bd6View commit details -
ADS: Mic and Camera permissions dialogs migration (#2649)
Task/Issue URL: https://app.asana.com/0/0/1203553010470144/f ### Description Migrate camera and microphone permission request dialogs to new components ### Steps to test this PR - Install from this branch - Go to a website which requests mic, camera or both permissions - [ ] Check dialog looks as expected - Go to Apps > DDG > Permissions and disable microphone permission - Go back to a website which requests microphone permission and allow it - [ ] Check Settings dialog look as expected ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221215_105042_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207844534-5409bae5-f954-4e88-aae0-bb35a6e4aac6.jpg)|![Screenshot_20221215_105631_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207844480-779e7b23-3c12-451e-98f2-ecee718a8286.jpg)| ![Screenshot_20221215_105136_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207844545-c1c09176-6932-49c3-b7c7-64b7f02c0ddc.jpg)|![Screenshot_20221215_105649_DuckDuckGo](https://user-images.githubusercontent.com/20798495/207844497-a2f2c435-b83c-4373-b545-ce1a72eeff04.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 5a50851 - Browse repository at this point
Copy the full SHA 5a50851View commit details -
ADS: AppTP - Onboarding (#2648)
Task/Issue URL: https://app.asana.com/0/72649045549333/1203568096239636 ### Description Update Onboarding screens and related: - Onboarding carrousel - FAQ page - Design Review in task
Configuration menu - View commit details
-
Copy full SHA for bcf3353 - Browse repository at this point
Copy the full SHA bcf3353View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8e3c92 - Browse repository at this point
Copy the full SHA d8e3c92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d100b - Browse repository at this point
Copy the full SHA 26d100bView commit details -
ADS: Browser Menu migration (#2682)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203514942123199 ### Description PR to update the Browser Menu specs Design review in https://app.asana.com/0/1174433894299346/1203600732931519
Configuration menu - View commit details
-
Copy full SHA for 6275ebc - Browse repository at this point
Copy the full SHA 6275ebcView commit details -
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203514942123197 ### Description PR to update Voice Search Design review in https://app.asana.com/0/1174433894299346/1203600732931512 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dfd55bd - Browse repository at this point
Copy the full SHA dfd55bdView commit details -
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203411647299665 ### Description PR to update the Remote Messaging views Design Review in https://app.asana.com/0/1174433894299346/1203593299114126 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a85b20 - Browse repository at this point
Copy the full SHA 1a85b20View commit details -
ADS: Share Feedback section (#2670)
Task/Issue URL: https://app.asana.com/0/0/1203467500325943/f **Description** Migration of share feedback screens to new components **_Design Review_** in https://app.asana.com/0/1195897901771673/1203575646431883
Configuration menu - View commit details
-
Copy full SHA for 4df9cc7 - Browse repository at this point
Copy the full SHA 4df9cc7View commit details -
AppTP [1/2]: Trackers Screen (#2666)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203577953787622 ### Description This PR updates the Tracker screen sections of AppTP to the latest designs ### Steps to test this PR Steps in https://app.asana.com/0/1174433894299346/1203578103740008 Co-authored-by: Noelia Alcala <nalcalag@gmail.com> Co-authored-by: Aitor Viana <aitorvs@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7aef662 - Browse repository at this point
Copy the full SHA 7aef662View commit details -
ADS: Destructive Colors (#2703)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/1202857801505092/1203560741717081 ### Description This PR updates the colors of destructive primary and ghost buttons
Configuration menu - View commit details
-
Copy full SHA for 24ea0a4 - Browse repository at this point
Copy the full SHA 24ea0a4View commit details -
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/1157893581871903/1203641318924982 ### Description This PR fixes. the issue in Android 8 where the dax bubble wasn't appearing ### Steps to test this PR _Fresh install_ - [ ] Fresh install - [ ] Ensure Dax Bubble appears during onboarding
Configuration menu - View commit details
-
Copy full SHA for 390bad5 - Browse repository at this point
Copy the full SHA 390bad5View commit details -
Task/Issue URL: https://app.asana.com/0/0/1203687084841383/f ### Description Migrate survey views to new components ### Test in Design Review Asana task: https://app.asana.com/0/1201807753394693/1203675383875628 ### UI changes | Before | After | | ------ | ----- | ![Screenshot 2023-01-11 at 17 47 53](https://user-images.githubusercontent.com/20798495/211880290-6b469d96-427f-43e8-9665-94c870a42076.png)|![Screenshot 2023-01-11 at 17 25 25](https://user-images.githubusercontent.com/20798495/211878507-adbe8d14-a02b-426a-95eb-21924e661eed.png)| ![Screenshot 2023-01-11 at 17 47 42](https://user-images.githubusercontent.com/20798495/211880284-5ab8dbeb-46a3-4cb2-9f9a-54856ca943a3.png)|![Screenshot 2023-01-11 at 17 25 40](https://user-images.githubusercontent.com/20798495/211878534-41db6aa0-36cb-4b39-affa-778c64401cf1.png)|
Configuration menu - View commit details
-
Copy full SHA for 1ea17d7 - Browse repository at this point
Copy the full SHA 1ea17d7View commit details -
ADS: Widgets migration (#2711)
Task/Issue URL: https://app.asana.com/0/0/1203411647299667/f ### Description Migrate widgets to new styles ### Steps to test this PR - Install from this branch - Add widget to your home screen - Check widgets match new designs ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20221230_163631_One UI Home](https://user-images.githubusercontent.com/20798495/210092677-96c4eaa8-4008-48d3-8ec2-25752184ed06.jpg)|![Screenshot_20221230_163636_One UI Home](https://user-images.githubusercontent.com/20798495/210092673-46145d5d-170c-4edc-8ccf-d5b7885f9591.jpg)|
Configuration menu - View commit details
-
Copy full SHA for 7453ad5 - Browse repository at this point
Copy the full SHA 7453ad5View commit details -
Task/Issue URL: https://app.asana.com/0/0/1203455585574665/f ### Description This PR fixes the search interstitial screen ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20230112_163749](https://user-images.githubusercontent.com/531613/212278920-8745b185-aa86-48c1-ab15-c45038c66483.png)|![Screenshot_20230112_163728](https://user-images.githubusercontent.com/531613/212278939-5b3fd40a-32d6-4e29-a87e-8ce81a0f40d4.png)|
Configuration menu - View commit details
-
Copy full SHA for e01ac92 - Browse repository at this point
Copy the full SHA e01ac92View commit details -
ADS: Toolbar Animations (#2713)
<!-- Note: This checklist is a reminder of our shared engineering expectations. The items in Bold are required If your PR involves UI changes: 1. Upload screenshots or screencasts that illustrate the changes before / after 2. Add them under the UI changes section (feel free to add more columns if needed) 3. Make sure these changes are tested in API 23 and API 26 If your PR does not involve UI changes, you can remove the **UI changes** section --> Task/Issue URL: https://app.asana.com/0/1157893581871903/1203532998797240 Task/Issue URL: https://app.asana.com/0/home/1157893581871899/1203532998797235 ### Description This PR fixes the toolbar animations as they appear with the wrong colors.
Configuration menu - View commit details
-
Copy full SHA for 918f418 - Browse repository at this point
Copy the full SHA 918f418View commit details -
ADS: Final bits and pieces (#2717)
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203411129606111 ### Description Final changes before Ship Review
Configuration menu - View commit details
-
Copy full SHA for 2e851cf - Browse repository at this point
Copy the full SHA 2e851cfView commit details -
Task/Issue URL: https://app.asana.com/0/1174433894299346/1203687084841388 ### Description This PR fixes the Popup Menus, ensuring no TextViews are used and the Browser Menu respects the disabled state ### Steps to test this PR Smoke test Browser Popup ### UI changes | Before | After | After | | ------ | ----- | ----- | ![Screenshot_20230111_125401](https://user-images.githubusercontent.com/531613/211800449-df2b9982-c78f-4140-a208-33ca5e99c64e.png)|![Screenshot_20230111_125308](https://user-images.githubusercontent.com/531613/211800453-6553f9e6-418b-47f3-91ec-839d58609b53.png)|![Screenshot_20230111_125238](https://user-images.githubusercontent.com/531613/211800457-ac30827b-0561-404b-bdf0-42acc8da4c53.png)|
Configuration menu - View commit details
-
Copy full SHA for fe858da - Browse repository at this point
Copy the full SHA fe858daView commit details -
ADS: Design Review Changes (#2730)
Task/Issue URLs: https://app.asana.com/0/0/1203721679624008/f https://app.asana.com/0/1202857801505092/1203499549142146/f https://app.asana.com/0/0/1203769028231491/f ### Description UI changes after final design review ### Steps to test this PR Asana task: https://app.asana.com/0/0/1203721679624008/f Co-authored-by: David González <malmstein@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ad60751 - Browse repository at this point
Copy the full SHA ad60751View commit details