Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming/appearance settings #44

Closed
Efreak opened this issue Sep 15, 2017 · 0 comments
Closed

Theming/appearance settings #44

Efreak opened this issue Sep 15, 2017 · 0 comments

Comments

@Efreak
Copy link

Efreak commented Sep 15, 2017 •
edited
Loading

Wrong repo... Not sure what Android app this is? I was looking fort search & stories app...
@Efreak Efreak closed this as completed Sep 15, 2017
aitorvs pushed a commit that referenced this issue May 6, 2021
@CDRussell
Replace use of Handlers to delay work to avoid ANR possibility (#44)
5b6a7f6 
I saw an ANR happening because the main thread was blocked awaiting packet handling. Upon investigating, the cause of this was using Handler to delay the execution of closing the connection (as that will run on the main thread). Instead, switched that small part to using coroutines and delay() instead.

Co-authored-by: Craig Russell <CDRussell@users.noreply.github.com>
karlenDimla added a commit that referenced this issue Apr 28, 2023
@karlenDimla
Drop netp pixels when netp cohort is not set (#44)
494059a 
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
    3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->

Task/Issue URL:
https://app.asana.com/0/1203137811378537/1203970993959741/f

### Description
This PR drops any netp pixels when the netp cohort is not yet assigned.

### Steps to test this PR

- [x] Install build from this PR
- [x] Open DDG browser
- [x] Verify that logcat shows `Pixel URL request dropped:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_netp_ev_disabled_d_android_phone?appVersion=5.149.1&test=1,`
- [x] Verify that logcat shows `Pixel URL request dropped:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_atp_ev_disabled_on_launch_c_android_phone?appVersion=5.149.1&test=1,`
- [x] Update `DeviceShieldStatusReporting` and
`NetworkProtectionStatusReporting` to update every 10 seconds instead.
- [x] Enable AppTP
- [x] Change date to next day.
- [x] Verify that logcat no longer shows `Pixel URL request dropped:
Request{method=GET, url=https://improving.duckduckgo.com/t/m_atp`
- [x] Verify that logcat shows `Pixel URL request fired:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_atp_ev_enabled_d`
- [x] Enable NetP
- [x] Change date to next day.
- [x] Verify that logcat no longer shows `Pixel URL request dropped:
Request{method=GET, url=https://improving.duckduckgo.com/t/m_netp`
- [x] Verify that logcat shows `Pixel URL request fired:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_netp_ev_enabled_d_android_phone?appVersion=5.149.1&test=1,`
aitorvs pushed a commit that referenced this issue Apr 30, 2023
@karlenDimla @aitorvs
Drop netp pixels when netp cohort is not set (#44)
affa9a0 
<!--
Note: This checklist is a reminder of our shared engineering
expectations.
The items in Bold are required
If your PR involves UI changes:
1. Upload screenshots or screencasts that illustrate the changes before
/ after
2. Add them under the UI changes section (feel free to add more columns
if needed)
    3. Make sure these changes are tested in API 23 and API 26
If your PR does not involve UI changes, you can remove the **UI
changes** section
-->

Task/Issue URL:
https://app.asana.com/0/1203137811378537/1203970993959741/f

### Description
This PR drops any netp pixels when the netp cohort is not yet assigned.

### Steps to test this PR

- [x] Install build from this PR
- [x] Open DDG browser
- [x] Verify that logcat shows `Pixel URL request dropped:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_netp_ev_disabled_d_android_phone?appVersion=5.149.1&test=1,`
- [x] Verify that logcat shows `Pixel URL request dropped:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_atp_ev_disabled_on_launch_c_android_phone?appVersion=5.149.1&test=1,`
- [x] Update `DeviceShieldStatusReporting` and
`NetworkProtectionStatusReporting` to update every 10 seconds instead.
- [x] Enable AppTP
- [x] Change date to next day.
- [x] Verify that logcat no longer shows `Pixel URL request dropped:
Request{method=GET, url=https://improving.duckduckgo.com/t/m_atp`
- [x] Verify that logcat shows `Pixel URL request fired:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_atp_ev_enabled_d`
- [x] Enable NetP
- [x] Change date to next day.
- [x] Verify that logcat no longer shows `Pixel URL request dropped:
Request{method=GET, url=https://improving.duckduckgo.com/t/m_netp`
- [x] Verify that logcat shows `Pixel URL request fired:
Request{method=GET,
url=https://improving.duckduckgo.com/t/m_netp_ev_enabled_d_android_phone?appVersion=5.149.1&test=1,`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Efreak