Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text should not have a heading tag if it's not a heading 🛀 #255

Closed
jagtalon opened this issue Aug 2, 2018 · 2 comments
Closed

Text should not have a heading tag if it's not a heading 🛀 #255

jagtalon opened this issue Aug 2, 2018 · 2 comments
Labels
Accessibility bug

Comments

@jagtalon
Copy link
Member

jagtalon commented Aug 2, 2018 •
edited

'Forced Encryption' probably shouldn't be h2 reading it using a screen reader doesn't sound right. It's not the start of a section.
frankieshakes pushed a commit to frankieshakes/duckduckgo-privacy-extension that referenced this issue Oct 27, 2018
Text should not have a heading tag if it's not a heading 🛀 duckduckgo…
300fddb 
…#255:

- Swapped H2 tags for P tags.
@vladhnat
Copy link

Hi 👋
I wanna contribute to this project and it would be great if this issue will be one of the first my contribution. 🎉
What the status of this issue❓
If the status is still the same then how can I assign it to myself and take it to the work❓
Thanks 🙂

kdzwinel added a commit that referenced this issue May 5, 2021
@frankieshakes @sammacbeth @kdzwinel
Text should not have a heading tag if it's not a heading 🛀 #255 (#346)
2b49b67 
* "Tracker Networks Top Offenders" section semantically comes before the site details 📄 #250:
- Adjusted CSS index
- Specified a 'before' selector to ensure the .site-info section appears before the Tracker Networks Top Offenders

* Revert ""Tracker Networks Top Offenders" section semantically comes before the site details 📄 #250:"

This reverts commit 984d782.

* Text should not have a heading tag if it's not a heading 🛀 #255:
- Swapped H2 tags for P tags.

* Fix merge

* Fix font weight for site privacy protection toggle label

* Fix bolding on "Added to unprotected sites" message.

Co-authored-by: Frank Manno <fmanno@digitalocean.com>
Co-authored-by: Sam Macbeth <sammacbeth@users.noreply.github.com>
Co-authored-by: Konrad Dzwinel <konrad@duckduckgo.com>
@kdzwinel
Copy link
Member

This was fixed by #346. Thank y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jagtalon @kdzwinel @vladhnat