Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference tests integration: Expire 1p tracking cookies tests #1043

Merged
merged 10 commits into from
Feb 10, 2022

Conversation

kdzwinel
Copy link
Member

@kdzwinel kdzwinel commented Feb 7, 2022

Reviewer: @sammacbeth

Description:

Integration of first party cookie expiry tests - https://github.com/duckduckgo/privacy-reference-tests/tree/main/expire-first-party-tracking-cookies.

Steps to test this PR:

  1. Only tests are affected so as long as they are passing and code looks ok we should be good.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@kdzwinel kdzwinel force-pushed the konrad/expire-1p-tracking-cookies-tests branch from 47e67a4 to 503098c Compare February 10, 2022 11:13
@kdzwinel kdzwinel marked this pull request as ready for review February 10, 2022 11:16
@kdzwinel kdzwinel merged commit 7b5d923 into develop Feb 10, 2022
@kdzwinel kdzwinel deleted the konrad/expire-1p-tracking-cookies-tests branch February 10, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants