Don't create Tab objects for initial tabs until config is loaded.

[sammacbeth]

Reviewer:

Description:

Fixes an issue where we incorrectly showed the message "temporarily disabled Privacy Protection" for all tabs which are open on extension start.

Steps to test this PR:

Automated tests:

• Unit tests
• Integration tests

Reviewer Checklist:

• Ensure the PR solves the problem
• Review every line of code
• Ensure the PR does no harm by testing the changes thoroughly
• Get help if you're uncomfortable with any of the above!
• Determine if there are any quick wins that improve the implementation

PR Author Checklist:

• Get advice or leverage existing code
• Agree on technical approach with reviewer (if the changes are nuanced)
• Ensure that there is a testing strategy (and documented non-automated tests)
• Ensure there is a documented monitoring strategy (if necessary)
• Consider systems implications

[kdzwinel]

Thanks for jumping on it Sam! Two things:

1. Can you explain why moving this code fixes the message?
2. I can see that the message is gone and I can see that stuff gets blocked on restored tabs, but popup doesn't seem to update with blocked content:

• load interia.pl
• don't approve the consent popup
• reload the extension
• approve the consent popup

what happens is that a bunch of trackers try to load and are blocked, but popup is showing 0

I think we can merge the message thing first and deal with that later if it will turn out to be a non-obvious to fix.

There is also one nit: extension icon doesn't update it shows Dax for me until I reload / navigate away. This might be related to 2, but might be separate. This is least important.

[sammacbeth]

Thanks for the review Konrad.

1/ When we create a new Site object we get the enabled features for it based on the config:

duckduckgo-privacy-extension/shared/js/background/utils.es6.js

Lines 192 to 201 in 2082d08

	export function getEnabledFeatures (url) {
	if (!tdsStorage.config.features) return
	const enabledFeatures = []
	for (const feature in tdsStorage.config.features) {
	if (isFeatureEnabled(feature) && brokenListIndex(url, tdsStorage.config.features[feature].exceptions || []) === -1) {
	enabledFeatures.push(feature)
	}
	}
	return enabledFeatures
	}

This requires that we've already loaded the tds config, otherwise the feature list is always empty. If the list is empty then we consider the site 'broken' in the UI and show the warning:

duckduckgo-privacy-extension/shared/js/ui/models/site.es6.js

Line 251 in 2082d08

this.isBroken = this.tab.site.isBroken || !this.tab.site.enabledFeatures.includes('contentBlocking')

This change moves the tab initialization code after we've done await tdsStorage.getLists() which will load the config, so we are guaranteed to have features loaded when we build the enabled feature list.

2/ This looks like another bug with tabs created on browser start. I just pushed another commit to fix that.

Usually, a Tab object is created from a main_frame request. However, when we create Tabs on startup, we don't have that, so use a chrome.tab object instead. In our blocking code we were only adding blocking info when the tab has statusCode = 200 though, which would never be the case for Tabs created from a chrome.tab object (because that object does not include a status code), so we would never add tracker info for tabs created in this way.

[kdzwinel]

LGTM, thanks so much Sam!

[kdzwinel]

I don't understand why we had this filtering, but as far as I can see this decision is >4y old, so we may never know.