Infrastructure to expand 3rd-Party Tracker Loading Protection #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the infrastructure we need to expand our 3rd-Party Tracker Loading Protection to include Microsoft, such that Microsoft scripts on our list are blocked from loading except for requests from one domain (bat.bing.com) loading on some advertiser websites following DuckDuckGo ad clicks. For more information, please see https://help.duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/#3rd-party-tracker-loading-protection
- ensure icons are the correct colour in all states - ensure text/descriptions are correct in all states - show the correct text for 'tracker networks' - various CSS fixes - reload the page when the popup is closed following a protections toggle - pass the correct model when determining explainer text on third parties screen
- Filter out first party requests from panel.
englehardt
approved these changes
Aug 7, 2022
- Remove independent.co.uk grading.
jonathanKingston
force-pushed
the
infra_to_expand_third_party_tracker_loading_protection
branch
from
5a93508
to
f20c7d0
Compare
jdorweiler
added a commit
that referenced
this pull request
Oct 24, 2022
* started on mv3 ad click * passes integration tests * use ddg2dnr * Update shared/js/background/classes/ad-click-attribution-policy.js Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> * add unique rule id, oneadclick per tab * lint * check that tab exists * use ad attribution priority * lint * lint * remove debug lines * remove debug lines * check for adClickDNR for mv2 * Update shared/js/background/classes/ad-click-attribution-policy.js Co-authored-by: Dave Vandyke <kzar@kzar.co.uk> * rename module * unused function * Apply suggestions from code review Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> Co-authored-by: Dave Vandyke <kzar@kzar.co.uk> * Apply suggestions from code review Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> * simplify session ids, move dnr stuff around * fix removal * everything in adclick * get offset from storage * set session id on startup * Update shared/js/background/dnr-session-rule-id.js Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> * Update shared/js/background/dnr-session-rule-id.js Co-authored-by: Dave Vandyke <kzar@kzar.co.uk> * Update shared/js/background/classes/ad-click-attribution-policy.js Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> * add tests * fix test * changes from pr review * add ready flag to session id * make linter happy Co-authored-by: Jonathan Kingston <jkingston@duckduckgo.com> Co-authored-by: Dave Vandyke <kzar@kzar.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @englehardt
Description:
Add the infrastructure we need to expand our 3rd-Party Tracker Loading Protection to include Microsoft, such that Microsoft scripts on our list are blocked from loading except for requests from one domain (bat.bing.com) loading on some advertiser websites following DuckDuckGo ad clicks. For more information, please see https://help.duckduckgo.com/duckduckgo-help-pages/privacy/web-tracking-protections/#3rd-party-tracker-loading-protection
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: