Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update #1313 for MV3 #1450

Merged
merged 37 commits into from
Oct 24, 2022
Merged

Update #1313 for MV3 #1450

merged 37 commits into from
Oct 24, 2022

Conversation

jdorweiler
Copy link
Contributor

Reviewer:

Description:

Updating #1313 for Chrome MV3

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

shared/js/background/dynamic-rule-id.js Outdated Show resolved Hide resolved
shared/js/background/dynamic-rule-id.js Outdated Show resolved Hide resolved
shared/js/background/dynamic-rule-id.js Outdated Show resolved Hide resolved
shared/js/background/events.es6.js Outdated Show resolved Hide resolved
shared/js/background/events.es6.js Outdated Show resolved Hide resolved
shared/js/background/events.es6.js Show resolved Hide resolved
kzar
kzar previously requested changes Oct 21, 2022
shared/js/background/dnr-session-rule-id.js Show resolved Hide resolved
shared/js/background/dnr-session-rule-id.js Show resolved Hide resolved
shared/js/background/dnr-session-rule-id.js Show resolved Hide resolved
shared/js/background/dnr-session-rule-id.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@jonathanKingston jonathanKingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; didn't test here but we can verify later. The code itself is looking very solid now thanks for all your work!

@jdorweiler jdorweiler removed the request for review from kzar October 24, 2022 22:48
@jdorweiler jdorweiler dismissed kzar’s stale review October 24, 2022 22:49

will make followups

@jdorweiler jdorweiler merged commit c7576f1 into develop Oct 24, 2022
@jdorweiler jdorweiler deleted the jd/mv3-adclick branch October 25, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants