Remove parameterName and parameterValue from ad-attribution feature to simplify code #1343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @englehardt
Description:
Marking draft as CI should fail if working correcly; testCases still need amending.
This is to simplify the parsing logic as we already verify an ad click based on the adDomainParameterName parameter name in the link click.
https://app.asana.com/0/0/1202808108652811/f
Corresponding config change should probably land first so we can just run bundle-config instead of hand hacking it: duckduckgo/privacy-configuration#345
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: