Bugfix: getBaseDomain should return null when invalid #1410
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in the ad domain detection where we expect getBaseDomain to return null when a domain provided by SERP is unparsable, but getBaseDomain will always return the hostname (even if it's nonsensical).
This is Ad 11 and Add 12 in https://www.search-company.site/
I also fixed a no-op test that we forgot to update when we first merged the bat.js work. I only detected it because I had an outdated privacy grade reference that was still returning
firstParty
when running the tests locally.Reviewer: @jonathanKingston
Description:
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: