Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump autofill and update copy #1436

Merged
merged 3 commits into from
Oct 6, 2022
Merged

Conversation

GioSensation
Copy link
Member

@GioSensation GioSensation commented Oct 6, 2022

Reviewer: @kzar

Description:

Steps to test this PR:

  • Specific autofill changes tested during the autofill release
  • Instructions for autofill smoke tests in the Asana task
  • To test the copy changes:
    • Open the popup and verify the copy
    • Click on Generate Private Duck Address and verify that the "Copied to clipboard" message appears correctly
    • With Email Protection turned on, visit https://privacy-test-pages.glitch.me/autofill/modal.html
    • The Email Tooltip and the contextual menu copy looks like the screenshots attached

CleanShot 2022-10-06 at 16 10 52@2x
CleanShot 2022-10-06 at 16 08 53@2x
CleanShot 2022-10-06 at 16 08 44@2x

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation GioSensation self-assigned this Oct 6, 2022
@GioSensation GioSensation requested a review from kzar October 6, 2022 15:11
@GioSensation GioSensation merged commit 1b87672 into develop Oct 6, 2022
@GioSensation GioSensation deleted the ema/bump-autofill-update-copy branch October 6, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants