-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chrome MV3 support for user allowlisting #1464
Conversation
8ccbc70
to
61eb183
Compare
ac3bd45
to
e3c2b3f
Compare
I'm getting the same startup error I was seeing in #1450 when I tried to include the declarative net module. |
e3c2b3f
to
c2c899e
Compare
@jdorweiler Dang, yea I have also seen that one cropping up. I'm going to file a follow-up task to investigate, it seems only tangentially (if at all) related to these changes. |
c2c899e
to
190fd76
Compare
Ignore I see you raised: https://app.asana.com/0/892838074342800/1203229345565679/f |
Users can allowlist (disable protections) for websites from the popup UI and also from the options page. To make that work with Chrome MV3, we need to add a declarativeNetRequest rule that ensures requests initiated by domains that the user has allowlisted aren't blocked or redirected.
190fd76
to
82c4732
Compare
@kzar looks good, I think you're just missing the page reload when toggling |
Users can allowlist (disable protections) for websites from the popup
UI and also from the options page. To make that work with Chrome MV3,
we need to add a declarativeNetRequest rule that ensures requests
initiated by domains that the user has allowlisted aren't blocked or
redirected.
Reviewer: @jdorweiler
CC: @jonathanKingston
Steps to test this PR:
npm install && npm run dev-chrome-mv3
).Automated tests:
Reviewer Checklist:
PR Author Checklist: