Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome MV3 Beta channel #1469

Merged
merged 6 commits into from
Oct 26, 2022
Merged

Chrome MV3 Beta channel #1469

merged 6 commits into from
Oct 26, 2022

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Oct 24, 2022

Reviewer:

Description:

https://app.asana.com/0/0/1203197597853167/f

  • Set up build process for a Chrome MV3 beta build.
  • Add an action that we can trigger to automatically publish a new version to the Chrome beta channel.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@sammacbeth sammacbeth force-pushed the mv3-beta-publish branch 5 times, most recently from c029d94 to dbcfd93 Compare October 25, 2022 12:08
@sammacbeth sammacbeth marked this pull request as ready for review October 25, 2022 14:02
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but it looks great. I've just left a couple of comments related to new action versions that I was forced to use in recent tests. Not sure if it applies here, but it's probably worth upgrading anyway. Up to you.

Also, please check the integration test failure. Not sure if it's related.

.github/workflows/beta.yml Outdated Show resolved Hide resolved
.github/workflows/beta.yml Outdated Show resolved Hide resolved
sammacbeth and others added 2 commits October 26, 2022 14:24
Prevents error when we might try to push to a protected branch (develop)
@sammacbeth sammacbeth merged commit a206dc1 into develop Oct 26, 2022
@sammacbeth sammacbeth deleted the mv3-beta-publish branch October 26, 2022 12:32
@sammacbeth sammacbeth mentioned this pull request Oct 27, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants