Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in beta workflow script #1477

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix errors in beta workflow script #1477

merged 2 commits into from
Oct 27, 2022

Conversation

sammacbeth
Copy link
Collaborator

Reviewer:

Description:

https://app.asana.com/0/0/1203197597853167/f

There was a typo in #1469 which broke the workflow after it was merged into develop. This PR fixes that.

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@sammacbeth sammacbeth merged commit f6fb618 into develop Oct 27, 2022
@sammacbeth sammacbeth deleted the mv3-beta-publish branch October 27, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioSensation GioSensation GioSensation approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sammacbeth @GioSensation