Switch Click to Load to the "clickToLoad" feature name

[kzar]

Initially the Click to Load feature was misnamed "clickToPlay". Also
the Facebook entity name was inconsistently called either "Facebook"
or "Facebook, Inc.". We have corrected those the extension
configuration, content-scope-scripts and the reference tests. Let's
update those dependencies and make the necessary extension changes
here.

Reviewer: @ladamski
CC: @kdzwinel

Testing

1. Ensure the unit tests still pass.
2. Ignore if Facebook integration tests are marked pending, Sam has a follow-up to switch to Playwright for those.
3. Edit the configuration and check the "clickToLoad" feature controls Facebook/YouTube Click to Load, instead of the "clickToPlay" feature.
4. Smoke test Click to Load still works.

Automated tests:

• Unit tests
• Integration tests

Reviewer Checklist:

• Ensure the PR solves the problem
• Review every line of code
• Ensure the PR does no harm by testing the changes thoroughly
• Get help if you're uncomfortable with any of the above!
• Determine if there are any quick wins that improve the implementation

PR Author Checklist:

• Get advice or leverage existing code
• Agree on technical approach with reviewer (if the changes are nuanced)
• Ensure that there is a testing strategy (and documented non-automated tests)
• Ensure there is a documented monitoring strategy (if necessary)
• Consider systems implications

[ladamski]

Code itself looks fine but I've had no luck building this locally, for dev or unit test. I get the following:

• make[1]: *** No rule to make target shared//content-scope-scripts/node_modules/puppeteer/.local-chromium/mac-1002410/chrome-mac/Chromium.app/Contents/Frameworks/Chromium', needed by build/chrome/dev/public/js/background.js'. Stop.

Have you run into this?

[kzar]

Code itself looks fine but I've had no luck building this locally, for dev or unit test. I get the following:

* make[1]: *** No rule to make target `shared//content-scope-scripts/node_modules/puppeteer/.local-chromium/mac-1002410/chrome-mac/Chromium.app/Contents/Frameworks/Chromium', needed by `build/chrome/dev/public/js/background.js'.  Stop.

Have you run into this?

@ladamski That's probably related to the recent changes to the build system. You might try clearing shared/content-scope-scripts and node_modules/ before running npm install again to see if it helps. That said, I have tested the changes my end.

[ladamski]

Got tests working after deleting shared/content-scope-scripts and unit tests pass. Though I'm still unable to test manually since npm run dev-chrome gets stuck in a copy loop for me, but I don't want to hold this up further due to my build issues.