Fix percent encoding errors for param stripping

[SlayterDev]

Reviewer: @jonathanKingston @kzar

Description:

This fixes url param stripping when parameters aren't properly percent decoded. Note I've also removed code that deals with Regex parameters as we no longer have these in our lists.

Steps to test this PR:

Make sure to enable queryParameters in your local config.

Check the tests here: https://privacy-test-pages.glitch.me/privacy-protections/query-parameters/

Automated tests:

• Unit tests
• Integration tests

Reviewer Checklist:

• Ensure the PR solves the problem
• Review every line of code
• Ensure the PR does no harm by testing the changes thoroughly
• Get help if you're uncomfortable with any of the above!
• Determine if there are any quick wins that improve the implementation

PR Author Checklist:

• Get advice or leverage existing code
• Agree on technical approach with reviewer (if the changes are nuanced)
• Ensure that there is a testing strategy (and documented non-automated tests)
• Ensure there is a documented monitoring strategy (if necessary)
• Consider systems implications

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1204621210866535

[kzar]

Looks good @SlayterDev , I've left some comments.

At a higher level though, I wonder if this should be two changes.

1. First change for rethinking uses of searchParams throughout the codebase. There might be other places where we use the API to add/remove parameters, and therefore adjust the encoding of parameters by mistake.
2. Second change for removing support for regular expression parameter stripping.

What do you think?

[jonathanKingston]

First change for rethinking uses of searchParams throughout the codebase. There might be other places where we use the API to add/remove parameters, and therefore adjust the encoding of parameters by mistake.

That sounds like a follow up investigation. I'd concentrate on this issue first to not add further risk.

[kzar]

Some failing unit tests to fix, but otherwise LGTM