Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable URL parameter stripping in the extension #954

Merged
merged 2 commits into from
May 25, 2023

Conversation

SlayterDev
Copy link
Collaborator

Asana Task: Fix stripping tracking parameters encoding leading to breakage in extensions

Description
This has been fixed in duckduckgo/duckduckgo-privacy-extension#1988

@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (7 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt
  • v1/android-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json

⚠️ File is identical

v1/extension-brave-config.json (9 more)
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
--- v1/extension-safarimv3-config.json
+++ v1/extension-safarimv3-config.json
@@ -13580,9 +13580,9 @@
                     "hmb_source",
                     "hmb_medium"
                 ]
             },
-            "state": "disabled"
+            "state": "enabled"
         },
         "userAgentRotation": {
             "settings": {
                 "agentExcludePatterns": []
latest
v2/android-config.json (3 more)
  • v2/android-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json

⚠️ File is identical

v2/extension-brave-config.json (9 more)
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
--- v2/extension-safarimv3-config.json
+++ v2/extension-safarimv3-config.json
@@ -13584,9 +13584,9 @@
                     "hmb_source",
                     "hmb_medium"
                 ]
             },
-            "state": "disabled"
+            "state": "enabled"
         },
         "userAgentRotation": {
             "settings": {
                 "agentExcludePatterns": []

@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (17 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json

⚠️ File is identical

latest
v2/android-config.json (3 more)
  • v2/android-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json

⚠️ File is identical

v2/extension-brave-config.json (9 more)
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
--- v2/extension-safarimv3-config.json
+++ v2/extension-safarimv3-config.json
@@ -13584,9 +13584,10 @@
                     "hmb_source",
                     "hmb_medium"
                 ]
             },
-            "state": "disabled"
+            "state": "enabled",
+            "minSupportedVersion": "2023.5.23"
         },
         "userAgentRotation": {
             "settings": {
                 "agentExcludePatterns": []

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I tested:

  • the flow that made us disable this
  • the fact that feature is enabled with "minSupportedVersion": "2023.5.23" and disabled with "minSupportedVersion": "2023.5.24" (AKA minSupportedVersion works as expected)

@sammacbeth sammacbeth merged commit 780ee8f into main May 25, 2023
3 checks passed
@sammacbeth sammacbeth deleted the brad/enable-params branch May 25, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants