Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seen before day on site breakage reports #2306

Merged
merged 13 commits into from
Nov 2, 2023
Merged

Conversation

jonathanKingston
Copy link
Collaborator

Reviewer:

Description:

https://app.asana.com/0/inbox/1199237043596759/1205588216029401/1205802892084402

Steps to test this PR:

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@jonathanKingston jonathanKingston force-pushed the jkt/seenBeforeDay branch 2 times, most recently from c4277c4 to 2bdf7c5 Compare October 27, 2023 14:09
@jonathanKingston jonathanKingston marked this pull request as ready for review October 30, 2023 20:35
@sammacbeth sammacbeth merged commit 7a6f94d into main Nov 2, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants