Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests were a little tricky to work with, for failures the
wrong line numbers were given and console.log() didn't work. Let's try
to improve the situation:
be used to report the line numbers correctly.
console.warn() or console.error() instead of console.log().
Note: Unfortunately adding inline sourcemaps seems to slow down
Karma/Jasmine quite a bit. In the future, we might consider
using a faster test runner, or one that supports external
sourcemaps.
Reviewer: @sammacbeth
CC: @jdorweiler
Description:
Steps to test this PR:
Automated tests:
Reviewer Checklist:
PR Author Checklist: