Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test usability #2463

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Commits on Mar 7, 2024

  1. Improve unit test usability

    The unit tests were a little tricky to work with, for failures the
    wrong line numbers were given and console.log() didn't work. Let's try
    to improve the situation:
    
    1. Have the unit tests bundled with inline sourcemaps, that can then
       be used to report the line numbers correctly.
    2. Add a note to the unit test's README to mention to use
       console.warn() or console.error() instead of console.log().
    
    Note: Unfortunately adding inline sourcemaps seems to slow down
          Karma/Jasmine quite a bit. In the future, we might consider
          using a faster test runner, or one that supports external
          sourcemaps.
    kzar committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    540e3e1 View commit details
    Browse the repository at this point in the history