Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links that should semantically be buttons #345

Merged
merged 3 commits into from
May 5, 2021
Merged

Update links that should semantically be buttons #345

merged 3 commits into from
May 5, 2021

Conversation

carolkng
Copy link
Contributor

@carolkng carolkng commented Oct 27, 2018 •
edited

Reviewer: @jagtalon

Description:

Adds the role=button attribute to the "X trackers blocked", "__ Privacy Practices" links in the hamburger menu, as well as the "Add to whitelist" link in the options menu.

Fixes #259
Fixes #256

Steps to test this PR:

  1. Open the Voiceover utility
  2. Navigate to the buttons and check that Voiceover recognizes them.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

carolkng and others added 3 commits October 26, 2018 23:10
@carolkng
Make "Add to whitelist" link a button
fb47688 
Signed-off-by: Carol Ng <carol@carolkng.com>
@carolkng
Change tracker and privacy links in hamburger menu to buttons
8b3731f 
"Manage Whitelist" and "Report Broken Site" left alone, as they
technically link to an external page.

Signed-off-by: Carol Ng <carol@carolkng.com>
@sammacbeth
Merge branch 'develop' into develop
6da813f
sammacbeth
sammacbeth approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@sammacbeth sammacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@sammacbeth sammacbeth merged commit bdb4ea5 into duckduckgo:develop May 5, 2021
kdzwinel pushed a commit that referenced this pull request May 5, 2021
@carolkng @sammacbeth @kdzwinel
Update links that should semantically be buttons (#345)
8ed325f 
* Make "Add to whitelist" link a button

Signed-off-by: Carol Ng <carol@carolkng.com>

* Change tracker and privacy links in hamburger menu to buttons

"Manage Whitelist" and "Report Broken Site" left alone, as they
technically link to an external page.

Signed-off-by: Carol Ng <carol@carolkng.com>

Co-authored-by: Sam Macbeth <sammacbeth@users.noreply.github.com>
@sammacbeth sammacbeth mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sammacbeth sammacbeth sammacbeth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@carolkng @sammacbeth