-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider removing @vercel/node from the dependencies #154
Comments
@fox1t, it might make sense to remove Vercel dep |
@ysgk are you using this package as a library? If so we should extract the needed parts and make it importable/requirable. I like the idea since it will transform this package into a monorepo. We can use https://github.com/ducktors/crane and inject the monorepo. |
@fox1t |
OK. We will work soon on this. Thanks for reporting! |
Might be a good solution. It will be a major bump and we need to provide an alternative. I need to think about it a little bit more. |
I would really appreciate it, if Vercel could remain as a option to deploy the custom cache to. :) |
I agree. I don't like to cut features we already have. |
🐛 Bug Report
Currently, the installation size of this package is huge. This is partly due to @vercel/node, which lists an old version of typescript as its dependency, not a peer dependency. The size of turborepo-remote-cache is 202MB, of which typescript alone is more than 50MB. If your project uses a newer version of typescript, as most likely it does, two different versions will be installed, which means typescript alone will be over 100MB in size. They are discussing about moving typescript to peer dependencies, but will not happen for the time being.
However, @vercel/node is currently only used for some trivial type information in this package:
VercelRequest
andVercelResponse
. These two type definitions are nothing but the following:It doesn't seem to me this is worth the 50MB disk size. Therefore, I suggest that you consider removing @vercel/dev, at least for the time being.
To Reproduce
Expected behavior
Only one version of typescript will be installed, reducing the installation size.
Your Environment
The text was updated successfully, but these errors were encountered: