references package even if no cited functions/methods used #48
Labels
Comments
|
well -- why not? we use it, so it's referenced :-) |
|
but we are not using any duecredited function... how do we know that we don't just import it? |
|
that's fair -- I will look into it On Sun, Aug 23, 2015 at 3:53 PM, Yaroslav Halchenko <
|
|
So I'm looking into this, AFAIU the issue comes from injector.py that is set up to always import the package if the module/functions are imported...but I don't know what would be the safest way to change it since I have to digest the code a bit more. Any suggestion? Here's the relevant debugging output |
mvdoc
changed the title
|
the analysis logic should happen during output, as it was before somewhat -- if there are no references triggered for submodules -- do not output that module reference (unless cite_module=True for that module, as we do for numpy only atm) |
|
Gotcha. Thanks for the hint |
|
closed by #86 |
yarikoptic
added a commit
that referenced
this issue
Jun 17, 2016
[Full Changelog](0.5.0...0.6.0) **Implemented enhancements:** - Support system-specific references [\#81](#81) - export to bibtex doesn't support tags yet [\#19](#19) - ENH: support DUECREDIT\_REPORT\_ALL=1 to report all citations, not only with functionality used [\#92](#92) ([yarikoptic](https://github.com/yarikoptic)) **Fixed bugs:** - Outputting to bibtex doesn't filter by used citations [\#68](#68) - references package even if no cited functions/methods used [\#48](#48) - When injecting multiple citations at the same point, only one referenced [\#47](#47) **Merged pull requests:** - BF: allow multiple injections at the same path, avoid resetting \_orig\_import if already deactivated [\#91](#91) ([yarikoptic](https://github.com/yarikoptic)) - DOC: Update readme to reflect current output of duecredit summary [\#89](#89) ([mvdoc](https://github.com/mvdoc)) - enable codecov coverage reports [\#87](#87) ([yarikoptic](https://github.com/yarikoptic)) - REF,ENH: refactor {BibTeX,Text}Output into Output class with subclasses [\#86](#86) ([mvdoc](https://github.com/mvdoc)) * tag '0.6.0': (39 commits) CHANGELOG DOC: clarify DUECREDIT_REPORT_ALL usage ENH: use any instead of list when filtering packages DOC: Update readme to show how to use the new flag TST: test also DUECREDIT_REPORT_TAGS while we're at it TST: test all the flags TST: test that DUECREDIT_REPORT_ALL works ENH: support DUECREDIT_REPORT_ALL=1 DOC: Update readme DOC: fix small change to readme DOC: update readme to reflect current output ENH: do not demand coverage for the code we hope should never be triggered BF: exec to figure out version should be done with locals(), globals() ???: naively hoping that previous bug triggered on travis would be gone fixed by prev fix ENH+RF: track per injector either it is active and do not deactivate in __del__ if not TST: add test for double injection BF+ENH(LOG): decorate prev decorated object during injection + improve logging enable codecov coverage reports Fix Py3 annoyances BF: BibTeXOutput returns only unique bibtexs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@mvdoc Why sklearn listed (not that it shouldn't since we use its functionality here but none of the decorated methods was called AFAIK)?
The text was updated successfully, but these errors were encountered: