REF,ENH: refactor {BibTeX,Text}Output into Output class with subclasses #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fails on python 3.x. will debug later |
|
One of the failures seems to be just difference in indentation in wrapped title of the XXX0 |
|
ok all tests pass now |
| @@ -161,8 +161,12 @@ def __contains__(self, entry): | |||
| return entry.path.startswith(self.path + '.') | |||
|
|
|||
| @property | |||
| def entry_key(self): | |||
| return self.entry.get_key() | |||
There was a problem hiding this comment.
Do we need it?
Why not to have key as a property in entry and then use entry.key
yarikoptic
added a commit
that referenced
this pull request
Jun 17, 2016
[Full Changelog](0.5.0...0.6.0) **Implemented enhancements:** - Support system-specific references [\#81](#81) - export to bibtex doesn't support tags yet [\#19](#19) - ENH: support DUECREDIT\_REPORT\_ALL=1 to report all citations, not only with functionality used [\#92](#92) ([yarikoptic](https://github.com/yarikoptic)) **Fixed bugs:** - Outputting to bibtex doesn't filter by used citations [\#68](#68) - references package even if no cited functions/methods used [\#48](#48) - When injecting multiple citations at the same point, only one referenced [\#47](#47) **Merged pull requests:** - BF: allow multiple injections at the same path, avoid resetting \_orig\_import if already deactivated [\#91](#91) ([yarikoptic](https://github.com/yarikoptic)) - DOC: Update readme to reflect current output of duecredit summary [\#89](#89) ([mvdoc](https://github.com/mvdoc)) - enable codecov coverage reports [\#87](#87) ([yarikoptic](https://github.com/yarikoptic)) - REF,ENH: refactor {BibTeX,Text}Output into Output class with subclasses [\#86](#86) ([mvdoc](https://github.com/mvdoc)) * tag '0.6.0': (39 commits) CHANGELOG DOC: clarify DUECREDIT_REPORT_ALL usage ENH: use any instead of list when filtering packages DOC: Update readme to show how to use the new flag TST: test also DUECREDIT_REPORT_TAGS while we're at it TST: test all the flags TST: test that DUECREDIT_REPORT_ALL works ENH: support DUECREDIT_REPORT_ALL=1 DOC: Update readme DOC: fix small change to readme DOC: update readme to reflect current output ENH: do not demand coverage for the code we hope should never be triggered BF: exec to figure out version should be done with locals(), globals() ???: naively hoping that previous bug triggered on travis would be gone fixed by prev fix ENH+RF: track per injector either it is active and do not deactivate in __del__ if not TST: add test for double injection BF+ENH(LOG): decorate prev decorated object during injection + improve logging enable codecov coverage reports Fix Py3 annoyances BF: BibTeXOutput returns only unique bibtexs ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #68, #48, and closes #83