Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded images in article body #16

Closed
jimpo opened this issue Jan 13, 2013 · 3 comments
Closed

Embedded images in article body #16

jimpo opened this issue Jan 13, 2013 · 3 comments
Assignees

Comments

@jimpo
Copy link
Member

jimpo commented Jan 13, 2013

No description provided.

@ghost ghost assigned grivkees Jan 13, 2013
@ghost ghost assigned themichaellai Feb 10, 2013
@jimpo
Copy link
Member Author

jimpo commented Apr 19, 2013

Is this finished? What else has to be done before we launch this?

@themichaellai
Copy link
Member

Alternating the placement of the pictures still doesn't work (for me at least), but I think that's all that has to be done.

@jimpo
Copy link
Member Author

jimpo commented Apr 23, 2013

Sorry, here's a curveball. We're using tinymce now in the admin interface. I need you to write a TinyMCE plugin to insert the image tags instead of having that standalone button. I pushed some stuff to the inline-media branch. Take a look at app/assets/javascripts/admin/tinymce-image.js. You will need to basically rewrite that code to pop up the image selector modal and create the tag and all that. You can gchat me with any questions.

@jimpo jimpo closed this as completed Nov 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants