Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popped out panels should have their own layouts #55

Open
NeusFear opened this issue Dec 14, 2020 · 2 comments
Open

Popped out panels should have their own layouts #55

NeusFear opened this issue Dec 14, 2020 · 2 comments
Assignees
Labels
backend The issue requires attention from the backend devs dev The issue pertains to the private dev site enhancement New feature or request UI/UX The issue requires attention from the frontend devs

Comments

@NeusFear
Copy link
Member

As css tends to be finicky I think that the best way to make sure that the popped-out panels work well and are responsive like the embedded versions we should have a way to style them independently. The main example of this being an issue is with the modeler "cube edit" pannel displaying everything in "block" form as opposed to in a grid or something more sensible.

I'll be happy to make these layouts if @Wyn-Price can code in the panels themselves. I think this would be nice to have a "panels" directory just like we have "tabs" and "modules" directories for these things.

@NeusFear NeusFear added the enhancement New feature or request label Dec 14, 2020
@Wyn-Price
Copy link
Member

The panels can have their own css, but the html tags have to be identical. This is because the html files are essentially cut and paste into the popout window

@NeusFear
Copy link
Member Author

On the react branch we could just pass a prop to pannels that can pop out as a boolean so we can decide what things should look like

@NeusFear NeusFear added backend The issue requires attention from the backend devs dev The issue pertains to the private dev site UI/UX The issue requires attention from the frontend devs labels Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend The issue requires attention from the backend devs dev The issue pertains to the private dev site enhancement New feature or request UI/UX The issue requires attention from the frontend devs
Projects
None yet
Development

No branches or pull requests

2 participants