Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create a simple animation generator #110

Closed
Akshat-Mishra101 opened this issue Aug 14, 2022 · 13 comments · Fixed by #113
Closed

[FEATURE] Create a simple animation generator #110

Akshat-Mishra101 opened this issue Aug 14, 2022 · 13 comments · Fixed by #113
Assignees
Labels
assigned Issue is no longer available for anyone else to work on feature released

Comments

@Akshat-Mishra101
Copy link
Contributor

Description

Hey guys i'm new to open source :), and I want to contribute to this project by adding a simple css animation generator that supports rotating objects, skewing them, fade-in and fade-out with the option to adjust the duration

Screenshots

No response

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 14, 2022

Wow, you just created your first issue on this project, that's so cool. Make sure to wait till you are allowed to work on this before you do and when you are allowed to, don't forget to mention this issue in your pull request [Automated]

@Akshat-Mishra101
Copy link
Contributor Author

Sure :)

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 14, 2022

If you want to work on this, let me know

@Akshat-Mishra101
Copy link
Contributor Author

Sure, I'd love to work on this. How can i start :)

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 14, 2022

Sure, I'd love to work on this. How can i start :)

Read this and this

@Dun-sin Dun-sin added the assigned Issue is no longer available for anyone else to work on label Aug 14, 2022
@Akshat-Mishra101
Copy link
Contributor Author

Thankyou, I'll start :)

@Akshat-Mishra101
Copy link
Contributor Author

Hey @Dun-sin, I was wondering to what degree am I allowed to introduce my styles for the new animation generator. Should i prefer sticking to the old styles or is small change is allowed? :)

I'm adding a radio button group for choosing the types of animations

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 16, 2022

Hey @Dun-sin, I was wondering to what degree am I allowed to introduce my styles for the new animation generator. Should i prefer sticking to the old styles or is small change is allowed? :)

I'm adding a radio button group for choosing the types of animations

Depends, I can't really pick if I don't see what you are doing

@Akshat-Mishra101
Copy link
Contributor Author

Screenshot (232)
Here's the change, I've introduced a new class for the radiobutton group

@Akshat-Mishra101
Copy link
Contributor Author

Also, a new style for the duration selection input and label

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 17, 2022

Screenshot (232) Here's the change, I've introduced a new class for the radiobutton group

Sure, it's okay by me

@Akshat-Mishra101
Copy link
Contributor Author

Thanks man, it's gonna look really good now :)

@Dun-sin
Copy link
Owner

Dun-sin commented Aug 22, 2022

🎉 This issue has been resolved in version 1.12.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned Issue is no longer available for anyone else to work on feature released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants