Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update topkg #93

Closed
hannesm opened this issue Nov 17, 2021 · 2 comments · Fixed by #127
Closed

update topkg #93

hannesm opened this issue Nov 17, 2021 · 2 comments · Fixed by #127

Comments

@hannesm
Copy link
Contributor

hannesm commented Nov 17, 2021

to released version 1.0.4
@emillon emillon mentioned this issue Mar 9, 2022
Open
38 tasks
@emillon emillon linked a pull request Mar 9, 2022 that will close this issue
[new release] topkg (1.0.5+dune) #127
Merged
@NathanReb
Copy link
Member

Do you have a concrete example where you need topkg in your monorepo? No package in opam (upstream and opam-overlays) depends on both topkg and dune so it seems that opam-monorepo would never lock topkg.

I might definitely be missing something here but in most cases topkg is used as an alternative to dune so I don't think there would be a reason to port it to dune for opam-monorepo. It's likely a mistake that it was ported initally.

@hannesm
Copy link
Contributor Author

hannesm commented Mar 21, 2022

It's likely a mistake that it was ported initally.

maybe. I opened this issue when checking which packages were used by my dependency cone. Now that I think about it, indeed having topkg in this overlay doesn't make much sense.

@hannesm hannesm closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new release] topkg (1.0.5+dune) emillon/opam-overlays
2 participants
@hannesm @NathanReb