Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed collect when some services return AccessDenied #776

Merged
merged 1 commit into from
Dec 3, 2020

Conversation

jtyers
Copy link
Contributor

@jtyers jtyers commented Oct 5, 2020

On our environment we have SCPs in place that deny access to some services and regions. Since these fail to return data cloudmapper encounters an error when reading this data back. This PR fixes that, by only reading the data if the files exist.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2020

CLA assistant check
All committers have signed the CLA.

@0xdabbad00
Copy link
Collaborator

Thank you @jtyers and sorry for the delay in getting to this. LGTM. This can be merged @steiza

@steiza steiza merged commit 5cd0480 into duo-labs:main Dec 3, 2020
@jtyers
Copy link
Contributor Author

jtyers commented Dec 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants