-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature tokio-rustls-tls requires native-tls? #396
Comments
This is already fixed in v0.35.0-alpha.1 |
What is the release timeline looking like? |
Is it possible to make a new full release now with this fix, and then add any other pending changes to the next full release? In case the release is being held back by some other work going on. |
I second this, this is a very crucial update. |
Following up again here, what is required for rust-s3 to be ready for a non-alpha release containing the dependency fix here? |
@emmiegit, published version |
Thank you for your help! |
Okay -- I thought I was mistaken but it seems I was not. I left a comment here: #395 (comment), basically it was working fine with |
Describe the bug
I'm looking at feature flag definition in
Cargo.toml
and the dependencies inCargo.lock
, and I noticed that thetokio-rustls-tls
feature depends onnative-tls
, rather than usingrustls
. This would explain build issues I am facing due to the compilation trying to look for an openssl which isn't there.I am noticing that the
with-tokio
feature in the flag list requirestokio-native-tls
,native-tls
, etc., whereas previouslywith-tokio
only required["reqwest", "tokio", "tokio/fs", "tokio-stream"]
. This seems to preclude any possibility of using Tokio with rustls, despite what the feature flag list would suggest.See
0.32.3
'sCargo.toml
compared to0.34.0
's.Why does using Tokio require native TLS? Is there a way I can use only rustls instead alongside Tokio?
Environment
1.79.0
0.34.0
Additional context
This issue occurred when trying to upgrade to
0.34.0
. See scpwiki/wikijump#1962.The text was updated successfully, but these errors were encountered: