Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving to PLONK/master outdated some README values #42

Closed
CPerezz opened this issue Apr 15, 2020 · 3 comments
Closed

Moving to PLONK/master outdated some README values #42

CPerezz opened this issue Apr 15, 2020 · 3 comments
Assignees
@vlopes11 @CPerezz
Milestone
Hades252 v0.3.0

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Apr 15, 2020 •
edited
Loading

Readme.md file mentions several times the RistrettoScalar Field which is no longer being used in master impl.

Instead, it is using the Scalar & G1Affine of dusk-network/Bls12_381 which is what the PLONK repo is currently relying on as a backend.

This info should be updated as well as the parameters that provide values related to the Fr group being used in the implementation.
@vlopes11
Copy link
Contributor

Agreed. Not only that, but the whole documentation is outdated

@CPerezz
Copy link
Contributor Author

CPerezz commented Apr 16, 2020

Will you update it as soon as it is migrated to master?

@vlopes11 vlopes11 mentioned this issue Apr 18, 2020
Closed
@CPerezz CPerezz changed the title Moving to Zexe outdated some README values Moving to PLONK/master outdated some README values Apr 18, 2020
@CPerezz CPerezz self-assigned this Apr 18, 2020
@CPerezz CPerezz added this to the Hades252 v0.3.0 milestone Apr 26, 2020
@CPerezz CPerezz mentioned this issue May 1, 2020
Merged
@CPerezz
Copy link
Contributor Author

CPerezz commented May 1, 2020

Closed via #48

@CPerezz CPerezz closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlopes11 vlopes11

@CPerezz CPerezz

Labels
None yet
Projects
None yet
Milestone
Hades252 v0.3.0
Development

No branches or pull requests
2 participants
@vlopes11 @CPerezz