Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix createSortitionHash description #1509

Closed
fed-franz opened this issue Mar 14, 2023 · 0 comments · Fixed by #1512
Closed

Fix createSortitionHash description #1509

fed-franz opened this issue Mar 14, 2023 · 0 comments · Fixed by #1512
Assignees
@fed-franz
Labels
type:docs deliverable should be documentation

Comments

@fed-franz
Copy link
Contributor

Issue
In createSortitionHash, the i parameter is indicated as iteration number, which sounds mistakenly related to the SA iterations.

Solution
Fix description stating that i is actually the number of the committee member being extracted.
@fed-franz fed-franz added the type:docs deliverable should be documentation label Mar 14, 2023
@fed-franz fed-franz self-assigned this Mar 14, 2023
@fed-franz fed-franz changed the title Fix Sortition description Fix createSortitionHash description Mar 14, 2023
@fed-franz fed-franz mentioned this issue Mar 22, 2023
Merged
@fed-franz fed-franz linked a pull request Mar 22, 2023 that will close this issue
Fix createSortitionHash description #1512
Merged
fed-franz added a commit that referenced this issue Apr 5, 2023
@fed-franz
Merge pull request #1512 from dusk-network/1509-fix-createsortitionha…
d9cc966 
…sh-description

Fix createSortitionHash description

Resolves #1509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fed-franz fed-franz

Labels
type:docs deliverable should be documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix createSortitionHash description dusk-network/dusk-blockchain
1 participant
@fed-franz