-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-harness multiple provisioners #1318
Conversation
60ff3a7
to
053afb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1318 +/- ##
==========================================
- Coverage 50.51% 41.74% -8.78%
==========================================
Files 145 144 -1
Lines 7544 9171 +1627
==========================================
+ Hits 3811 3828 +17
- Misses 3066 4759 +1693
+ Partials 667 584 -83
Continue to review full report at Codecov.
|
4d3c2e6
to
5fc001b
Compare
- Wallets folder can be overwrite
Update default state root
5fc001b
to
a1dd2fe
Compare
@@ -26,7 +26,7 @@ const ( | |||
MaxInvBlocks = 500 | |||
|
|||
// Protocol-based consensus step time. | |||
ConsensusTimeOut = 20 * time.Second | |||
ConsensusTimeOut = 5 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back to 5s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was the timeout prior to increase block time to 15secs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fuzzy about the sleep
before the state transition operations. The rest looks fine
@@ -122,6 +122,8 @@ type executor struct { | |||
|
|||
// VerifyStateTransition see also Executor.VerifyStateTransition. | |||
func (e *executor) VerifyStateTransition(ctx context.Context, calls []ContractCall, blockGasLimit, blockHeight uint64) error { | |||
time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the sleeps for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (sleeps will be tackled in a followup issue)
Send transfer from faucet to provisionerStake from each provisionerResolves #1317