Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-harness multiple provisioners #1318

Merged
merged 3 commits into from
Mar 8, 2022
Merged

Test-harness multiple provisioners #1318

merged 3 commits into from
Mar 8, 2022

Conversation

herr-seppia
Copy link
Member

@herr-seppia herr-seppia commented Mar 1, 2022

  • Add reward generator to the rusk command
  • Send transfer from faucet to provisioner
  • Stake from each provisioner
  • Include more stakers in the genesis block

Resolves #1317

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2022

Codecov Report

Merging #1318 (60aacad) into master (828364b) will decrease coverage by 8.77%.
The diff coverage is n/a.

❗ Current head 60aacad differs from pull request most recent head 5fc001b. Consider uploading reports for the commit 5fc001b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1318      +/-   ##
==========================================
- Coverage   50.51%   41.74%   -8.78%     
==========================================
  Files         145      144       -1     
  Lines        7544     9171    +1627     
==========================================
+ Hits         3811     3828      +17     
- Misses       3066     4759    +1693     
+ Partials      667      584      -83     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.27% <0.00%> (-52.71%) ⬇️
pkg/rpc/client/session.go 21.42% <0.00%> (-47.15%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39818f0...5fc001b. Read the comment docs.

@herr-seppia herr-seppia changed the title WIP multi test-harness Test-harness multiple provisioners Mar 7, 2022
@herr-seppia herr-seppia marked this pull request as ready for review March 7, 2022 11:18
@herr-seppia herr-seppia self-assigned this Mar 7, 2022
@@ -26,7 +26,7 @@ const (
MaxInvBlocks = 500

// Protocol-based consensus step time.
ConsensusTimeOut = 20 * time.Second
ConsensusTimeOut = 5 * time.Second
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

back to 5s?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was the timeout prior to increase block time to 15secs

Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fuzzy about the sleep before the state transition operations. The rest looks fine

@@ -122,6 +122,8 @@ type executor struct {

// VerifyStateTransition see also Executor.VerifyStateTransition.
func (e *executor) VerifyStateTransition(ctx context.Context, calls []ContractCall, blockGasLimit, blockHeight uint64) error {
time.Sleep(1 * time.Second)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the sleeps for?

@autholykos autholykos self-requested a review March 8, 2022 08:53
Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (sleeps will be tackled in a followup issue)

@herr-seppia herr-seppia merged commit 2dbe451 into master Mar 8, 2022
@herr-seppia herr-seppia deleted the reward-generator branch March 8, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add staking smoke tests
3 participants