Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deadline context for Accept, Finalize and Persist rusk grpc calls #1323

Merged
merged 1 commit into from
Mar 6, 2022

Conversation

goshawk-3
Copy link
Contributor

fixes #1200

@codecov-commenter
Copy link

Codecov Report

Merging #1323 (fb77faf) into master (828364b) will decrease coverage by 8.66%.
The diff coverage is n/a.

❗ Current head fb77faf differs from pull request most recent head 474a01a. Consider uploading reports for the commit 474a01a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   50.51%   41.85%   -8.67%     
==========================================
  Files         145      144       -1     
  Lines        7544     9167    +1623     
==========================================
+ Hits         3811     3837      +26     
- Misses       3066     4745    +1679     
+ Partials      667      585      -82     
Impacted Files Coverage Δ
pkg/core/consensus/testing/node.go 0.00% <0.00%> (-93.55%) ⬇️
...ore/consensus/blockgenerator/candidate/testutil.go 0.00% <0.00%> (-90.91%) ⬇️
pkg/core/consensus/testing/utils.go 0.00% <0.00%> (-75.61%) ⬇️
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (-69.24%) ⬇️
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (-64.29%) ⬇️
pkg/gql/query/transactions.go 13.27% <0.00%> (-52.71%) ⬇️
pkg/util/nativeutils/eventbus/eventbus.go 57.14% <0.00%> (-42.86%) ⬇️
pkg/rpc/client/session.go 26.19% <0.00%> (-42.39%) ⬇️
pkg/rpc/client/client.go 3.73% <0.00%> (-36.61%) ⬇️
pkg/core/consensus/reduction/aggregator.go 56.25% <0.00%> (-35.06%) ⬇️
... and 165 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8879ac...474a01a. Read the comment docs.

Copy link
Member

@autholykos autholykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goshawk-3 goshawk-3 merged commit 39818f0 into master Mar 6, 2022
@goshawk-3 goshawk-3 deleted the fix-1200 branch March 6, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable client-side timeout for grpc ExecuteStateTransition
3 participants