Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: configuration should be created if it does not exist #647

Closed
autholykos opened this issue Mar 16, 2022 · 1 comment · Fixed by #657
Closed

wallet: configuration should be created if it does not exist #647

autholykos opened this issue Mar 16, 2022 · 1 comment · Fixed by #657
Assignees

Comments

@autholykos
Copy link
Member

Describe what you want implemented
During the first run of the wallet, if the configuration .toml does not exist, it should be generated on behalf of the user and placed in the default folder.
Describe "Why" this is needed
A user should be able to change configuration parameters.

Describe alternatives you've considered
The generation could be interactive (e.g. through a wizard process) or it can be as simple as telling the user where the configuration gets created (so she can twick it by herself).

@t00ts
Copy link
Contributor

t00ts commented Mar 16, 2022

As per yesterday's conversation, the wallet was going to be shipped with a valid configuration file pointing to a running cluster. That was the sole reason as to why this (rather large) refactor was done.

Is this no longer the case?

cc @Fulviuus

@autholykos autholykos changed the title Wallet: Configuration should be created if it does not exist wallet: Configuration should be created if it does not exist Mar 17, 2022
@autholykos autholykos changed the title wallet: Configuration should be created if it does not exist wallet: configuration should be created if it does not exist Mar 17, 2022
@t00ts t00ts self-assigned this Mar 17, 2022
t00ts added a commit that referenced this issue Mar 17, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 17, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants