Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: Config file loading fails silently #655

Closed
t00ts opened this issue Mar 17, 2022 · 0 comments · Fixed by #657
Closed

wallet: Config file loading fails silently #655

t00ts opened this issue Mar 17, 2022 · 0 comments · Fixed by #657
Assignees
@t00ts
Labels
fix:bug Something isn't working

Comments

@t00ts
Copy link
Contributor

t00ts commented Mar 17, 2022

Describe the bug
When no config.toml is found the wallet fails silently and uses default configuration. This is suboptimal because more often than not Rusk connection will fail and the user is given no feedback about why.
@t00ts t00ts added the fix:bug Something isn't working label Mar 17, 2022
@t00ts t00ts self-assigned this Mar 17, 2022
t00ts added a commit that referenced this issue Mar 17, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
30a34f4 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
@t00ts t00ts mentioned this issue Mar 17, 2022
Merged
t00ts added a commit that referenced this issue Mar 17, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
e13c130 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
7ea88a4 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
d1f40ab 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
793a8a6 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
t00ts added a commit that referenced this issue Mar 18, 2022
@t00ts
rusk-wallet: major refactor in path handling and user flow
a7bac2f 
- `data_dir` is used accross the board
- create configuration file if not exists
- notify user when defaulting configuration
- main flow is easier to understand

Resolves #647
Resolves #655
Resolves #656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t00ts t00ts

Labels
fix:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rusk-wallet: major refactor in path handling and user flow dusk-network/rusk
1 participant
@t00ts