Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in erosion outputs #42

Closed
dvalters opened this issue Apr 1, 2021 · 2 comments
Closed

Bug in erosion outputs #42

dvalters opened this issue Apr 1, 2021 · 2 comments

Comments

@dvalters
Copy link
Owner

dvalters commented Apr 1, 2021

Problem

  • If I try to input one grainsize only, the output still gives me a volume of sediment for all 9 grain sizes.
@dvalters dvalters added the bug? label Apr 1, 2021
@dvalters
Copy link
Owner Author

dvalters commented Apr 1, 2021

  • possibly not a bug. further tests to be done to confirm and follow up (may just have been an issue with .o files needing deleting by running make clean first before recompiling.

@dvalters
Copy link
Owner Author

dvalters commented Apr 1, 2021

Update: seems to have solved the issue now by recompiling.

My own test gave me zeros in all the sediment values but could be just because velocity/shear stress wasn't high enough to pick up or deposit that particular hard coded grain size in the short run Boscaslte test. Maggie's test seems to be working now anyway and she is getting singular values for the d1 grain size when d2-d9 are set to 0.0 for their respective proportions in the dprop[11] grain proportion array. (And recompile after clearing the old .o object files) (See also #40, but not essential to implement this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant