Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The arrow keys can now be held down #3

Merged
merged 1 commit into from
Mar 7, 2012
Merged

Conversation

angelos
Copy link
Contributor

@angelos angelos commented Mar 6, 2012

Hi,

Playing with the game, I noticed you need to press the arrow keys awfully fast to get the gun to move. I introduced handler for keys that are being held down (I didn't include the space in that).

Angelo

@angelos
Copy link
Contributor Author

angelos commented Mar 6, 2012

Hm, I probably should not ask you to pull from my master. Ah well, this is my first pull request. Is it better practice to create a specific branch for this?

dvberkel added a commit that referenced this pull request Mar 7, 2012
The arrow keys can now be held down
@dvberkel dvberkel merged commit ac09a8b into dvberkel:master Mar 7, 2012
@dvberkel
Copy link
Owner

dvberkel commented Mar 7, 2012

@angelos Thanks for your contribution. It makes the game a lot more playable.

In regard to pulling from master, I have no problems with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants