Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with Kotlin-DSL for gradle #57

Open
beigirad opened this issue Jun 24, 2019 · 5 comments
Open

incompatible with Kotlin-DSL for gradle #57

beigirad opened this issue Jun 24, 2019 · 5 comments

Comments

@beigirad
Copy link

Description

When I'm using Kotlin-DSL for build script files, daggraph does not recognize ptoject. and shows this error :

This is not a gradle folder

Steps to reproduce

  • Go to root of project
  • daggraph .

Expected behaviour

nothing

Screenshot

nothing

@nuhkoca
Copy link

nuhkoca commented Nov 8, 2019

Yes, agree. I need a quick solution for this, tho :/

@nuhkoca
Copy link

nuhkoca commented Nov 11, 2019

@dvdciri help, please :)

As I see, you have below check on the codebase but I am not sure why it is throwing this error.

function isGradleFolder(rootPath){
  return fs.existsSync(path.join(rootPath, 'build.gradle')) || fs.existsSync(path.join(rootPath, 'build.gradle.kts'));
}

@flywheelms
Copy link

Any update on this issue?

@dvdciri
Copy link
Owner

dvdciri commented Jan 23, 2020

Pull requests are welcome. Sorry I don't have much time to look into this right now but it seems like we need to improve the way we determine if the folder is the root of an android project. Currently using the gradle file, but we should come up with a better and more reliable solutions. Or remove the check altogether.

@logoped583st
Copy link

logoped583st commented Feb 15, 2021

The main issue that #56 was not published to npm.
last publish: Aug 19, 2018
pr merged: Jan 27, 2019
I have opened sources in node module and fond

if (!isGradleFolder(rootPath)) {
      log(_chalk.default.red("This is not a gradle folder"));
      process.exit(2);
    } // Scan the folder structure and get the dagger components

quick solution: clone repo and run npm start with path to your android project
@dvdciri can you please take a look for that and publish a new version when you have some time to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants