Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace implementation with vanilla oauth2 use #4

Closed
dvdmuckle opened this issue May 23, 2020 · 2 comments
Closed

Replace implementation with vanilla oauth2 use #4

dvdmuckle opened this issue May 23, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@dvdmuckle
Copy link
Owner

dvdmuckle commented May 23, 2020

https://github.com/dvdmuckle/goify/blob/e0832a4c29879ab6a66a3f2b1b8de08b1da593d8/cmd/helper/authHelp.go#L97-L100

@dvdmuckle dvdmuckle added enhancement New feature or request hacktoberfest labels Aug 30, 2020
@kmarrip
Copy link
Contributor

kmarrip commented Oct 15, 2021

hey @dvdmuckle can you add more context to this,
would love take this up

@dvdmuckle
Copy link
Owner Author

hey @dvdmuckle can you add more context to this,
would love take this up

Sure thing! So, the library used on that code snippet (which is a bit outdated, I'll get a fresh one there soon) to refresh the token, imported as spotifyAuth, is only used in that block of code, and isn't used anywhere else in the program. The goal here is to move the implementation of refreshing the token to an already imported library, such as the Golang oauth2 library. This is basically to remove the library and reduce binary size, since the library is only used in one place.

This was referenced Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants