Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When watching a netflix series, the next episodes goes back to 16:9 #27

Open
alba4k opened this issue Jul 29, 2024 · 10 comments
Open

When watching a netflix series, the next episodes goes back to 16:9 #27

alba4k opened this issue Jul 29, 2024 · 10 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request planned

Comments

@alba4k
Copy link

alba4k commented Jul 29, 2024

Describe the bug
Say I am watching a series on netflix. When pressing "next episode", I have to go out of fullscreen and back in to have the video played at 16:10 again.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the end of an episode on netflix
  2. Click on 'Next episode'
  3. It's back to 16:9

Expected behavior
The aspect ratio should be preserved

Desktop (please complete the following information):

  • OS: Arch Linux
  • Browser Firefox
  • Version 128.0.3
@alba4k alba4k added the bug Something isn't working label Jul 29, 2024
@dvlden
Copy link
Owner

dvlden commented Jul 29, 2024

Thank you for reporting the issue @alba4k !
I believe this is known issue since v2, so it's been there for a while.

Just checked to make sure and sounds about right.

Netflix doesn't replace video source path with the new episode. Instead they replace entire wrapper and video element and UW doesn't know about that change.

The problem I'm seeing here is that UW has been made to be memory efficient and doesn't do anything until you make an video player go into full-screen. That's when it knows which element to target.

I can probably whip something up over the weekend to test if I can create some type of watcher using the observer, but run it only while player is in full-screen and disconnect from it when full-screen closes.

I'm swamped at my 9-5 job and I think the fastest I can try this is over this weekend. :/

@dvlden dvlden added the planned label Jul 29, 2024
@alba4k
Copy link
Author

alba4k commented Jul 29, 2024

That sounds great!

Don't pressure yourself though, this should totally not be considered a priority ahah

@dvlden
Copy link
Owner

dvlden commented Aug 3, 2024

An update is coming up to the Chrome and Firefox store shortly.
I was able to make it work without performance penalties.

Once an update arrives and you test it, please let me know if there are no issues?
Also, if you are using any other platforms similar to Netflix where skipping the episode or loading the next one were breaking the effect applied by the extension, please do test and provide me feedback if possible.

Best regards.

@alba4k
Copy link
Author

alba4k commented Aug 5, 2024

immagine

Haven't gotten anything yet

@dvlden
Copy link
Owner

dvlden commented Aug 5, 2024

Firefox is slow with approvals. It usually takes about one week for them to review it.
Sorry about that 😐

@alba4k
Copy link
Author

alba4k commented Aug 9, 2024

Sorry for the delay.

Working like a charm, great!

@alba4k alba4k closed this as completed Aug 9, 2024
@alba4k
Copy link
Author

alba4k commented Aug 9, 2024

Uhm, nope actually

I just noticed that it appears to be working fine with this button
immagine

But this one is still broken
immagine

also completely unrelated but 1/8/2024 is appearing as 18/2024
immagine

@alba4k alba4k reopened this Aug 9, 2024
@dvlden
Copy link
Owner

dvlden commented Aug 9, 2024

Ahhh that's too bad! Will inspect further and see if it's fixable. :)
The unrelated part is correct. It's built in 2018, so 18/2024. I assume you meant it's release of 1st of August 2024?

@alba4k
Copy link
Author

alba4k commented Aug 10, 2024

yeah I read that as 01/08/2024

2018-24 would be clearer

@dvlden
Copy link
Owner

dvlden commented Aug 31, 2024

Hahah, fair enough. I'll make it 2018/2024 to be clearer.
I'll have to remove this feature of observer because I noticed higher memory usage and someone reported that it stopped working on Twitch #30 after this update.

Can't reproduce the issue with Twitch, but can't be coincidence.
Will try harder to think of a way to resolve this problem with and without Next episode click in one of the future releases.

Keeping it open for now.

@dvlden dvlden added the enhancement New feature or request label Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request planned
Projects
None yet
Development

No branches or pull requests

2 participants